Closed Bug 1981760 Opened 11 months ago Closed 11 months ago

Ensure the pinned tab periphery element is always last in the pinned tabs container

Categories

(Firefox :: Tabbed Browser, task, P1)

task
Points:
1

Tracking

()

RESOLVED DUPLICATE of bug 1981766

People

(Reporter: sthompson, Unassigned)

References

Details

(Whiteboard: [fidefe-sidebar])

Discussion from :dao in https://phabricator.services.mozilla.com/D260156:

Is #pinned-tabs-container-periphery guaranteed to come last? I guess it isn't since pinTab just uses native appendChild, whereas we have this for the unpinned container: https://searchfox.org/mozilla-central/rev/f6a806c38c459e0e0d797d264ca0e8ad46005105/browser/components/tabbrowser/content/tabs.js#1947,1955-1958

Seems like it's possible for #updateTabStylesOnDrag to create the pinned tabs periphery element but then for other code to place a tab after the pinned tabs periphery element. That would violate the invariant we have right now that the pinned tabs periphery element is supposed to be the last element of the pinned tabs container. We should address that.

Status: NEW → RESOLVED
Closed: 11 months ago
Duplicate of bug: 1981766
Resolution: --- → DUPLICATE
No longer blocks: 1970666
You need to log in before you can comment on or make changes to this bug.