Closed Bug 1981771 Opened 6 months ago Closed 6 months ago

[wpt-sync] Sync PR 54190 - layout: Floor content-box size by zero when stretching flex item

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
143 Branch
Tracking Flags:
Tracking Status
firefox143 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 54190 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/54190
Details from upstream follow.

Oriol Brufau <obrufau@igalia.com> wrote:

layout: Floor content-box size by zero when stretching flex item

When stretching the cross size of a flex item to its flex line, we were computing the stretch size by subtracting padding, border and margin from the line size. However, this could result in a negative amount for the content-box cross size. Therefore, this floors it by zero.

Testing: Adding new tests
Fixes: #<!-- nolink -->38517

Reviewed in servo/servo#38521

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 61 tests

Status Summary

Firefox

OK : 37
PASS: 2[GitHub] 825[Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt] 840[Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt] 841[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt]
FAIL: 142[Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt] 150[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt] 151[Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt]

Chrome

PASS: 2

Safari

PASS: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/b24c91013cd7 https://hg.mozilla.org/integration/autoland/rev/82795fdb45ac [wpt PR 54190] - layout: Floor content-box size by zero when stretching flex item, a=testonly

https://hg.mozilla.org/mozilla-central/rev/82795fdb45ac

Status: NEW → RESOLVED
Closed: 6 months ago
status-firefox143: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 143 Branch
You need to log in before you can comment on or make changes to this bug.