1981777 - Only compress Linux builds with xz parameters optimizing for binary size for shippable builds

Status: RESOLVED FIXED

(Release Engineering :: General, task)

Description

[Florian Quèze [:florian]]

A Linux artifact build job on try spends a large proportion of its time in xz --compress --stdout -9 --extreme (https://share.firefox.dev/4fuo6yr shows 1min38 out of a 3min51 build job).

The target.tar.xz file weights 82.7MB.

With the -9 --extreme parameters removed (https://share.firefox.dev/40XWQ5k), the xz --compress --stdout command now takes 18.4s (out of a 2min46 build job). The target.tar.xz file weights 85.2MB. I think that's a good tradeoff for non-shippable builds.

Comment 1

[Florian Quèze [:florian]]

Attachment: Bug 1981777 - Only compress Linux builds with xz parameters optimizing for binary size for shippable builds, r=#firefox-build-system-reviewers.

Comment 2

[Florian Quèze [:florian]]

The profiles in my try push confirm the patch is working as expected:

• shippable build, the -9 --extreme parameters are present and compressing took 1min49s: https://share.firefox.dev/4os9zaj
• opt build, compressing took 22.4s: https://share.firefox.dev/4fxdFKu (notice the package-tests phase 1min29s now takes longer than the package 41.6s one).

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2a05368e5cc6
https://hg.mozilla.org/integration/autoland/rev/04ad70684b7a
Only compress Linux builds with xz parameters optimizing for binary size for shippable builds, r=firefox-build-system-reviewers,nalexander.

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/04ad70684b7a

Comment 5

[Mayank Bansal]

as a datapoint, this increased the Linux64 non-shippable installer size by 2.9MB