1981861 - [composable toolbar] status bar color does not match custom toolbar background color in custom tabs

Status: RESOLVED FIXED

(Firefox for Android :: Toolbar, defect, P3)

Description

[Michel Le Bihan]

Steps to reproduce

1. Open a Fenix custom tab with an app that sets setToolbarColor
2. Notice that the status bar (the system bar on top of the screen) only follows the device theme and doesn't match the toolbar color

Expected behavior

The status bar color should match the toolbar color or at least be dark when the toolbar color is dark and the other way around.

Actual behavior

The status bar color follows the device theme and does not match the custom toolbar background color.

Device information

• Firefox version: -
• Android device model: -
• Android OS version: -

Any additional information?

Comment 1

[Petru-Mugurel Lingurar [:petru]]

This is an issue affecting the toolbar View also.
Postponing this for later.

Comment 2

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1981861 - part 1 - New Window.setSystemBarsBackground to theme system bars even when edge-to-edge is enabled r=#android-reviewers

When edge-to-edge is enabled Android doesn't theme anymore the system bars
so we have to do it ourselves.
The new method allows configuring the window background for the status bar,
the navigation bar and any horizontal insets but it is state-less - calling
it again with a different colour will reset the backgrounds set before.

Comment 3

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1981861 - part 2 - Theme system bars when using custom tabs with the Toolbar View r=#android-reviewers

Comment 4

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1981861 - part 2 - Theme system bars when using custom tabs with the composable toolbar r=#android-reviewers

Comment 5

[Phabricator Automation]

Comment on attachment 9507107 [details]
Bug 1981861 - part 2 - Theme system bars when using custom tabs with the Toolbar View r=#android-reviewers

Revision D261096 was moved to bug 1983103. Setting attachment 9507107 [details] to obsolete.

Comment 6

[Petru-Mugurel Lingurar [:petru]]

Attachment: WIP: Bug 1981861 - part 2 - Update composable toolbar parameter name to avoid asking for behavior

Small update to the naming to provide data instead of behavior through the State.

Comment 7

[Petru-Mugurel Lingurar [:petru]]

Attachment: WIP: Bug 1981861 - part 3 - Add search being started from a loaded website to the search state

This was needed to support trending/shortcuts/past searches suggestions
which are to be shown only for searches started from a loaded website
as long as there is no user typed search query.

Comment 8

[Phabricator Automation]

Comment on attachment 9507836 [details]
WIP: Bug 1981861 - part 2 - Update composable toolbar parameter name to avoid asking for behavior

Revision D261557 was moved to bug 1982356. Setting attachment 9507836 [details] to obsolete.

Comment 9

[Phabricator Automation]

Comment on attachment 9507837 [details]
WIP: Bug 1981861 - part 3 - Add search being started from a loaded website to the search state

Revision D261558 was moved to bug 1982356. Setting attachment 9507837 [details] to obsolete.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f7ab1282ae66
https://hg.mozilla.org/integration/autoland/rev/1feee6c62130
part 1 - New Window.setSystemBarsBackground to theme system bars even when edge-to-edge is enabled r=android-reviewers,mcarare
https://github.com/mozilla-firefox/firefox/commit/2e6821254636
https://hg.mozilla.org/integration/autoland/rev/be8044e078ce
part 2 - Theme system bars when using custom tabs with the composable toolbar r=android-reviewers,mcarare

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/1feee6c62130
https://hg.mozilla.org/mozilla-central/rev/be8044e078ce