1981982 - Important dates are locale restricted and fed by different RS collections

Status: VERIFIED FIXED

(Firefox :: Address Bar, task, P3)

Description

[Adrian Florinescu [:aflorinescu]]

Found in

• Nightly 143.0a1;

Affected versions

• Nightly 143.0a1;

Tested platforms

• Affected platforms: Windows 11, Mac 13, Ubuntu 24

Preconditions

• browser.urlbar.quicksuggest.dynamicSuggestionTypes = important_dates
• browser.urlbar.quicksuggest.enabled = true
• browser.urlbar.suggest.quicksuggest.nonsponsored = true
• Remote-Settings connected to Dev

Steps to reproduce

1. Region to US, type ramadan to trigger Important dates suggestion
2. Region to RO, type ramadan to trigger Important dates suggestion

Expected result

• there are different locales RS collections feeding different important dates, since the list would be different for different locales
• if there is no collection available for a given region, the important dates should return nothing, even if the feature is enabled.
• region would determine if the feature is enabled or disabled.

Actual result (see screenshots)

• currently it seems like the setup and results are not region/RS collection based

Additional Notes:

• For QA testing purposes, at least 2 RS collections should be setup up with 2 test locales to test this out, even if, for now the data set up is bogus.

Comment 1

[Adrian Florinescu [:aflorinescu]]

Updating this to task type, since this was required for testing the feature with locale RS setup.

Comment 2

[James Teow [:jteow]]

Moritz, is there anything to add in this bug? Is it for example still a bug based on your discussion with QA?

Comment 3

[Moritz Beier [:mbeier]]

It's not a bug. We'll add the full list of dates to non-us locales to remote settings soon (during beta) and then we can test if the right dates are available in the right locales.

Comment 4

[Mark Banner (:standard8)]

Cristian, given comment 3, are you happy to close this for now, or do you want it open for testing/tracking?

Comment 5

[Cristian Baica [:cbaica], Release Desktop QA]

We'll keep it open for now, until the preliminary testing phase is over. We'll make sure this is covered during testing so that we can close it after if everything is in good shape.

Comment 6

[Drew Willcoxon :adw]

This has been fixed, the QA ticket was resolved with a green status, and this feature is now on by default in 143, so I think we can close it. Thanks Adrian and Cristian!