1982021 - ChromeUtils.importESModule returns any and prevents type usage

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, defect)

Description

[Mark Kennedy [:mark]]

Attachment: EventEmitter_any_type.png

The return type of ChromeUtils.importESModule is incorrectly set to any in lib.gecko.dom.d.ts which is preventing us from checking or using the type of a class returned from it or anything that extends it.

For example the EventEmitter type used at the top of toolkit/content/preferencesBindings.js results in any, so type checking of the class is lost throughout the rest of the file. See attachment.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1982021 - Add TypeScript definitions for ChromeUtils.importESModule. r?zombie!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f492e48d9358
https://hg.mozilla.org/integration/autoland/rev/228df64f42b1
Add TypeScript definitions for ChromeUtils.importESModule. r=zombie

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/228df64f42b1

Comment 4

[Mark Striemer [:mstriemer]]

Moving regression to blocks since we really needed this to be updated to support bug 1976049