1982031 - The market Opt In section is displayed for a split second when focusing the Address bar if previously a google suggestion was focused before abandoning the results panel

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Valentin Bandac [:vbandac], Ecosystem QA]

[Affected versions]:

• Firefox Nightly 143.0a1 (Build ID: 20250808040847)

[Affected Platforms]:

• Windows 11 x64
• Ubuntu 24.04 x64
• macOS 15.3

[Prerequisites]:

• Have a Firefox Nightly 143 installed.
• Be connected to a “US” server using a VPN client.
• Set the following prefs with the next values:
  -> browser.search.region = US
  -> browser.newtabpage.activity-stream.asrouter.devtoolsEnabled = true
  -> browser.urlbar.quicksuggest.enabled = true
  -> browser.urlbar.suggest.realtimeOptIn = true
  -> browser.urlbar.quicksuggest.dynamicSuggestionTypes = realtime_opt_in
  -> browser.urlbar.quicksuggest.dataCollection.enabled = false
  -> browser.urlbar.merino.timeoutMs = 2000
• Using the RS addon, change the environment to Stage and restart the browser.

[Steps to reproduce]:

1. Open the browser with the profile from prerequisites.
2. Focus the Address Bar.
3. Type a market specific keyword (e.g.: stocks, shares, s and p, netflix stock, etc.).
4. Focus a google suggestion (that is NOT another specific keyword) using the keyboard.
5. Dismiss the results panel by pressing ESC or clicking outside of it.
6. Click on the address bar in order to display the results panel.
7. Observe the results panel.

[Expected result]:

• The results are displayed for the last focused suggestion from Step 4.
• The “Opt-in” section is NOT displayed.

[Actual result]:

• The results are displayed for the last focused suggestion from Step 4.
• The “Opt-in” section is displayed for a split second.

[Notes]:

• Attached a screen recording of the issue.

Comment 1

[Mark Banner (:standard8)]

If we're not going to be displaying it, we should probably clear it before we open the address bar pop-up.

Comment 2

[Daisuke Akatsuka (:daisuke)]

Thanks! This is still reproducible. I will take a look at this issue.

Comment 3

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1982031: Defer opening the urlbar view until receiving results when the query string is changing

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/59e851ff7325
https://hg.mozilla.org/integration/autoland/rev/26905533af21
Defer opening the urlbar view until receiving results when the query string is changing r=adw

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/26905533af21

Comment 6

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:daisuke, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox143 to wontfix.

For more information, please visit BugBot documentation.

Comment 7

[Drew Willcoxon :adw]

Attachment: Bug 1982031: Defer opening the urlbar view until receiving results when the query string is changing

Original Revision: https://phabricator.services.mozilla.com/D261689

Comment 8

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: This is required for the "carrots" realtime-suggestions Suggest feature in 143.
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: Should be clear from the bug
• Risk associated with taking this patch: low
• Explanation of risk level: This is a one-line change that prevents the urlbar panel from opening too soon and showing old suggestions.
• String changes made/needed: none
• Is Android affected?: no

Comment 9

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/9cac045fbdbd
https://hg.mozilla.org/releases/mozilla-beta/rev/0a882b87afc7

Comment 10

[Carmen Fat [:cfat] - Ecosystem QA]

I have verified this issue on the latest Firefox Nightly 144.0a1 (Build ID: 20250826095322) and Beta 143.0b4 (Build ID: 20250825091315) on Windows 11, macOS 15.3, and Ubuntu 24.04 x64.

• The Opt In section is no longer displayed when focusing the Address Bar if a search engine suggestion string is displayed in its input field instead of the previous market keyword.

Comment 11

[Acasandrei Beatrice (needinfo me)]

(In reply to Pulsebot from comment #4)

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/59e851ff7325
https://hg.mozilla.org/integration/autoland/rev/26905533af21
Defer opening the urlbar view until receiving results when the query string
is changing r=adw

Perfherder has detected a mozperftest performance change from push 26905533af21b36ddacf0c55ebffd585184bd326.

If you have any questions, please reach out to a performance sheriff. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
11%	background-resource cpuTime-gpu-50%	android-hw-a55-14-0-aarch64-shippable		283.85 -> 251.67

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a performance sheriff to do that for you.

You can run all of these tests on try with ./mach try perf --alert 46551

The following documentation link provides more information about this command.