GTK Titlebar Buttons / Window Controls Don't Show background with adw-family themes
Categories
(Core :: Widget: Gtk, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox143 | --- | fixed |
People
(Reporter: lordmethenor, Assigned: emilio)
References
Details
Attachments
(2 files, 1 external file)
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:141.0) Gecko/20100101 Firefox/141.0
Steps to reproduce:
- Set theme to adw-gtk3 (compiled from source or latest release (6.2))
- Open Firefox Beta (Linux x64, using Fedora 42 workstation on bare metal and VM)
Actual results:
The window controls are positioned correctly but have no backdrop.
Expected results:
There should have been a backdrop as there was prior to v140.
Comment 2•1 year ago
|
||
The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.
Two "Comments" that don't belong inside the bug report itself.
- I think I found and fixed the issue, but I don't know how to actually contribute to source. In the initial fix,
Adwis capitalized, butadw-gtk3and related themes (including my personal fork) use a lowercasea. I tested building adw-gtk3 with the project name 'Adw-gtk3' and setting theme toAdw-gtk3and the issue resolved.
I fully understand Firefox has no obligation or expectation to support alternative gtk themes, but it seems from the comment that it was the contributor's (:emilio) explicit intent.
As a user of such themes, I have no problem with this and thank them for the inclusion, but if checking for the name of an alternative theme is non a long-term solution, I might suggest (albeit with zero firefox development experience) the inclusion of a config option in the vein of widget.gtk.libadwaita-colors.enabled for the libadwaita window button placement and background regardless of detected theme.
- Comparing the screenshots, I noticed the headerbar height seems to change slightly when adw-gtk3 is enabled. I'm not filing a bug report because I have no clue if this is caused by Firefox or the theme or if it is even a bug at all, but it might indicate the window controls are not centered vertically either with the default theme or adw-gtk3, but I will file one if it is requested.
I also ran into
| Assignee | ||
Updated•1 year ago
|
| Assignee | ||
Comment 5•1 year ago
|
||
Updated•1 year ago
|
Comment 7•1 year ago
|
||
| bugherder | ||
Updated•1 year ago
|
Description
•