Closed Bug 1982248 Opened 1 year ago Closed 1 year ago

GTK Titlebar Buttons / Window Controls Don't Show background with adw-family themes

Categories

(Core :: Widget: Gtk, defect)

Firefox 142
defect

Tracking

()

RESOLVED FIXED
143 Branch
Tracking Status
firefox143 --- fixed

People

(Reporter: lordmethenor, Assigned: emilio)

References

Details

Attachments

(2 files, 1 external file)

Attached image firefox-142-adw-gtk.png —

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:141.0) Gecko/20100101 Firefox/141.0

Steps to reproduce:

  1. Set theme to adw-gtk3 (compiled from source or latest release (6.2))
  2. Open Firefox Beta (Linux x64, using Fedora 42 workstation on bare metal and VM)

Actual results:

The window controls are positioned correctly but have no backdrop.

Expected results:

There should have been a backdrop as there was prior to v140.

Attached image firefox-142-Adwaita.png —

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: Untriaged → Widget: Gtk
Product: Firefox → Core

Two "Comments" that don't belong inside the bug report itself.

  1. I think I found and fixed the issue, but I don't know how to actually contribute to source. In the initial fix, Adw is capitalized, but adw-gtk3 and related themes (including my personal fork) use a lowercase a. I tested building adw-gtk3 with the project name 'Adw-gtk3' and setting theme to Adw-gtk3 and the issue resolved.

I fully understand Firefox has no obligation or expectation to support alternative gtk themes, but it seems from the comment that it was the contributor's (:emilio) explicit intent.

As a user of such themes, I have no problem with this and thank them for the inclusion, but if checking for the name of an alternative theme is non a long-term solution, I might suggest (albeit with zero firefox development experience) the inclusion of a config option in the vein of widget.gtk.libadwaita-colors.enabled for the libadwaita window button placement and background regardless of detected theme.

  1. Comparing the screenshots, I noticed the headerbar height seems to change slightly when adw-gtk3 is enabled. I'm not filing a bug report because I have no clue if this is caused by Firefox or the theme or if it is even a bug at all, but it might indicate the window controls are not centered vertically either with the default theme or adw-gtk3, but I will file one if it is requested.

I also ran into

Emilio, any idea here?
Thanks.

Flags: needinfo?(emilio)
Flags: needinfo?(emilio)
Assignee: nobody → emilio
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 143 Branch
QA Whiteboard: [qa-triage-done-c144/b143]
See Also: → 2003691
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: