1982300 - [composable toolbar] Fx-Suggest telemetry is not recorded

Status: VERIFIED FIXED

(Firefox for Android :: Toolbar, defect, P2)

Description

[Petru-Mugurel Lingurar [:petru]]

Attachment: Fx Suggest.png

Steps to reproduce

1. Type a search query that would give Firefox suggest results
2. Press back to exit search or click on any suggestion

Expected behavior

• FXSuggest impression is recorded for all shown sponsored suggestions
• FXSuggest click is recorded for all clicked sponsored suggestions

Actual behavior

• No FXSuggest telemetry

Any additional information?

This issue does not reproduce for the toolbar View.

Comment 1

[Petru-Mugurel Lingurar [:petru]]

Seems like the issue happens because of this missing call to update the BrowserState with what suggestions are currently showing depending on which here we would compute what FXSuggestions were interacted with.

Comment 2

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1982300 - Ensure FXSuggest telemetry can be computed for the composable toolbar r=#android-reviewers

We were missing knowing what suggestions are shown based on which later we could
record telemetry for shown or clicked Firefox Suggest suggestions.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/4838228e4717
https://hg.mozilla.org/integration/autoland/rev/3a9f3729df00
Ensure FXSuggest telemetry can be computed for the composable toolbar r=android-reviewers,harrisono

Comment 4

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/3a9f3729df00

Comment 5

[Mira Lobontiu (Android QA)]

Verified as fixed on the Firefox for android Nightly 144.0a1 from 8/26 with a Samsung Galaxy S24 (Andorid 15).
The fx_suggest telemetry is being sent successfully.