Make it possible to delete uploaded profiles from about:logging
Categories
(Core :: XPCOM, enhancement, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox144 | --- | fixed |
People
(Reporter: canova, Assigned: canova)
References
(Blocks 1 open bug)
Details
Attachments
(5 files)
Bug 1803607 added a way to upload profiles from about:logging. But currently there is no way to delete them if they are uploaded through about:logging.
We should:
- Save the jwt token that we get from here (we save it in indexeddb in the frontend) That uploadResult is the jwt token that we just discard. We can include some more information from the profile data like we do in the profiler frontend.
- Show a list of "uploaded profiles" in about:logging with a "delete" button on the side.
- Send a request with that jwt token to the profiler server with the delete request (similar to here) when that button is pressed
|
Assignee | |
Updated•3 months ago
|
|
|
Assignee | |
Comment 1•3 months ago
|
||
They were fine in CI, but running them locally was showing some expected
failures about persisting some preferences.
|
||
Updated•3 months ago
|
|
|
Assignee | |
Comment 2•3 months ago
|
||
This patch doesn't use the code yet, it just adds the storage logic for
us to use in the following patch.
|
|
Assignee | |
Comment 3•3 months ago
|
||
|
|
Assignee | |
Comment 4•3 months ago
|
||
|
|
||
Updated•3 months ago
|
|
|
Assignee | |
Comment 5•3 months ago
|
||
Previously, when we were saving the profile to disk, we getting the
profile path from the localized string. But it appears that due to some
rendering timing issues, the rendered text might not contain the path
yet. But we will always have it inside the data-l10n-args attribute.
That's why it's better to check that directly.
|
||
Comment 8•3 months ago
|
||
|
|
Assignee | |
Comment 9•3 months ago
|
||
Huh, it's weird. I can't reproduce the lint failure locally, or in try. I pushed a try build here without code changes and I can't see it: https://treeherder.mozilla.org/jobs?repo=try&revision=7f3fa4d165454f3ec3051fd5019aff6c48e505ef&selectedTaskRun=dWRLnxgMTJ2OwvYNmNw_aQ.0
I don't know how to reproduce this, but looking at the failure in CI, this is the log:
[task 2025-09-03T21:08:34.723+00:00] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/toolkit/content/aboutLogging/aboutLogging.css:37:3 | var(--aboutlogging-border-radius-small) should be using a border-radius design token. This may be fixable by running the same command again with --fix. (stylelint-plugin-mozilla/use-border-radius-tokens)
[task 2025-09-03T21:08:34.724+00:00] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/toolkit/content/aboutLogging/aboutLogging.css:158:3 | var(--aboutlogging-border-radius-small) should be using a border-radius design token. This may be fixable by running the same command again with --fix. (stylelint-plugin-mozilla/use-border-radius-tokens)
This looks like a false positive, because --aboutlogging-border-radius-small is already using the border-radius design token with a fallback to normal values. This is done this way, specifically so it works on Android, because these tokens are not shipped in Android. See bug 1986645.
I will try to add stylelint-disable-next-line use-border-radius-tokens and land it again.
|
|
Assignee | |
Comment 10•3 months ago
|
||
Okay, I can reproduce it after rebasing my patches on top of main.
|
||
Comment 11•3 months ago
|
||
|
||
Comment 12•3 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/c113fa93abe5
https://hg.mozilla.org/mozilla-central/rev/19c8ec18087e
https://hg.mozilla.org/mozilla-central/rev/b657f23b326f
https://hg.mozilla.org/mozilla-central/rev/3c2aaab450d1
https://hg.mozilla.org/mozilla-central/rev/9a13e7146b08
Description
•