1982330 - Use optimization for constant global object properties in more cases

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P2)

Description

[Jan de Mooij [:jandem]]

Bug 1981133 enabled this optimization for GetName for data properties on the global object. This is the most common case, but there are some other places where we can take advantage of this:

• GetProp through the window proxy: {window,globalThis,this}.foo
• Getter properties. This is fairly common for DOM properties, for example "window" and "performance" are global getters.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1982330 part 1 - Share more CacheIR generator code for getters and setters. r?iain!

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1982330 part 2 - Optimize constant global data properties for GetProp on the WindowProxy. r?iain!

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Bug 1982330 part 3 - Optimize constant global getters for Get{G}Name. r?iain!

The constant-property tracking works also for accessor properties. This gets rid
of more shape guards for the global object and global lexical environment, and
that's good because these objects are often reshaped for new properties.

Comment 4

[Jan de Mooij [:jandem]]

Attachment: Bug 1982330 part 4 - Optimize constant global getters for GetProp on the WindowProxy. r?iain!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/82f0811bded0
https://hg.mozilla.org/integration/autoland/rev/71d77bff5137
part 1 - Share more CacheIR generator code for getters and setters. r=iain
https://github.com/mozilla-firefox/firefox/commit/39844f89f05d
https://hg.mozilla.org/integration/autoland/rev/08591fe8c670
part 2 - Optimize constant global data properties for GetProp on the WindowProxy. r=iain
https://github.com/mozilla-firefox/firefox/commit/c74c3d70502e
https://hg.mozilla.org/integration/autoland/rev/6f8c7c672dbd
part 3 - Optimize constant global getters for Get{G}Name. r=iain
https://github.com/mozilla-firefox/firefox/commit/79711968ac86
https://hg.mozilla.org/integration/autoland/rev/7f9343ee3137
part 4 - Optimize constant global getters for GetProp on the WindowProxy. r=iain

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/71d77bff5137
https://hg.mozilla.org/mozilla-central/rev/08591fe8c670
https://hg.mozilla.org/mozilla-central/rev/6f8c7c672dbd
https://hg.mozilla.org/mozilla-central/rev/7f9343ee3137