Closed Bug 1982375 Opened 2 months ago Closed 2 months ago

Black logos from the market suggestions are hardly visible when Dark Theme is enabled

Categories

(Firefox :: Address Bar, defect, P2)

Desktop
All
defect

Tracking

()

VERIFIED FIXED
144 Branch
Tracking Status
firefox143 --- verified
firefox144 --- verified

People

(Reporter: cfat, Assigned: adw)

References

(Blocks 1 open bug)

Details

(Whiteboard: [sng])

Attachments

(2 files)

[Affected versions]:

  • Firefox Nightly 143.0a1 (Build ID: 20250810210608)

[Affected Platforms]:

  • Windows 11 x64
  • Ubuntu 24.04 x64
  • macOS 15.3

[Prerequisites]:

  • Have a Firefox Nightly 143 installed.
  • Be connected to a “US” server using a VPN client.
  • Set the following prefs with the next values:
    -> browser.search.region = US
    -> browser.urlbar.quicksuggest.enabled = true
    -> browser.urlbar.suggest.realtimeOptIn = true
    -> browser.urlbar.quicksuggest.dynamicSuggestionTypes = realtime_opt_in
    -> browser.urlbar.quicksuggest.dataCollection.enabled = false
    -> browser.urlbar.merino.timeoutMs = 2000
  • Using the RS addon, change the environment to Stage and restart the browser.
  • Have the browser’s Dark Theme enabled.

[Steps to reproduce]:

  1. Open the browser with the profile from prerequisites.
  2. Focus the Address Bar.
  3. Type a market specific keyword (e.g.: stocks, shares, s and p, netflix stock, etc.).
  4. Click the “Show suggestions” button.
  5. Type the “pypl” market specific keyword in the Address Bar.
  6. Observe the logo of the market suggestion.

[Expected result]:

  • The logo is clearly visible.

[Actual result]:

  • The black logo is hardly visible due to it being displayed on a dark background.

[Notes]:

  • This issue is also reproducible for other market suggestions such as “mcd” and “aapl”.
  • Attached is a screenshot of the issue.

Similar to bug 1982037.

Priority: -- → P2
See Also: → 1982037
Attached image mcd's

I think we can call this fixed by bug 1982026 (not yet landed) due to the image background it adds, although there might be room for improvement still. It also uses the correct aspect ratio for images that aren't square.

Assignee: nobody → adw
Status: NEW → ASSIGNED
Depends on: 1982026
Whiteboard: [sng]
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 144 Branch
Flags: qe-verify+
Flags: in-testsuite-

I have verified this issue on the latest Firefox Nightly 144.0a1 (Build ID: 20250901162158) and Beta 143.0b7 (Build ID: 20250901090535) on Windows 11 x64, Ubuntu 24.04 x64, and macOS 15.3.

  • The black logo is visible now that it's displayed on a grey background.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: