1982387 - Follow-ups for xHE-AAC playback

Status: NEW

(Core :: Audio/Video: Playback, defect, P3)

Description

[Paul Adenot (:padenot)]

We need to do the following items, after discussion with Fraunhofer (who performed some tests on our current implementation):

• Only seek to key frames (unlike every other codec we have in tree, xHE-AAC requires this, so this requires a bit of plumbing + testing)
• Fix an issue in which we're not setting up the DRC correctly on macOS
• Add tests with test files that they have provided w/ permission to copy the file in tree

There is a last remaining item related to internal clipping somewhere in our playback pipeline, but I'm leaving it for another bug.

Comment 1

[Paul Adenot (:padenot)]

Attachment: Bug 1982387 - Allow requiring a seek to key-frames for audio, enable this mode when demuxing xHE-AAC. r?#media-playback-reviewers

Comment 2

[Paul Adenot (:padenot)]

Attachment: Bug 1982387 - Add various tests around MP4 index and demuxing. r?#media-playback-reviewers

Comment 3

[Paul Adenot (:padenot)]

Attachment: Bug 1982387 - Reference our new xhe-aac file in mochitest to test playback. r?#media-playback-reviewers

Comment 4

[Paul Adenot (:padenot)]

Attachment: Bug 1982387 - Properly check the codec when setting the target level and DRC properies in AppleATDecoder. r?#media-playback-reviewers

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:jimm, could you have a look please?

For more information, please visit BugBot documentation.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:jimm, could you have a look please?

For more information, please visit BugBot documentation.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:jimm, could you have a look please?

For more information, please visit BugBot documentation.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:padenot, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.