1982573 - [composable toolbar] Long-tap on the custom tab's URL doesn't trigger the context menu

Status: RESOLVED FIXED

(Firefox for Android :: Toolbar, defect, P2)

Description

[Mira Lobontiu (Android QA)]

Steps to reproduce

1. Enable the "Compose Toolbar" from Secret settings.
2. Make Firefox for Android the default browser.
3. Go to Gmail, or other app to open a custom tab.
4. Open a link as a custom tab.
5. Long-tap on the custom tab's URL.

Expected behavior

The context menu is triggerred with the "copy" option.

Actual behavior

Nothing happens.

Device information

• Firefox version: Nightly 143.0a1 from 8/10
• Android device: Oppo Find X3 Lite (Android 11), Google Pixel 6 (Android 16)

Any additional information?

• NOT reproducible with composable toolbar disabled

Comment 1

[Petru-Mugurel Lingurar [:petru]]

This was indeed an overlook.
Since currently we use the same token/color for the toolbar and popups I've checked with UX if this should still be the case for custom tabs - eg: if the toolbar is blue should popups also be blue?
Posting here the response from Nicole:

Keep the (custom) color just for the toolbar and keep context menu and browser menu the same as what we have in Firefox respecting light/dark mode. I'm worried that we will run into accessibility, legibility issues, and keeping the browser color will also look more recognizable, trustworthy.

Comment 2

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1982573 - Style popups separately from the toolbar r=#android-reviewers

While the toolbar can have a custom color in custom tabs the popups shown
from the toolbar (the search selector or popup menus) will still follow the
application's theme.

Comment 3

[Petru-Mugurel Lingurar [:petru]]

Abandoning this after talking more with Noah about rather first adopting the new M3 tokens.

Comment 4

[Petru-Mugurel Lingurar [:petru]]

Sorry, the theming part should be another ticket - we already have bug 1983833 for it but we can make the context menu work in this ticket.

Comment 5

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1982573 - Show an option to copy the url when long clicking on the addressbar in custom tabs r=#android-reviewers

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/05bbce22fe39
https://hg.mozilla.org/integration/autoland/rev/c7900e1079b2
Show an option to copy the url when long clicking on the addressbar in custom tabs r=android-reviewers,Roger

Comment 7

[amarc]

https://hg.mozilla.org/mozilla-central/rev/c7900e1079b2

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:petru, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox143 to wontfix.

For more information, please visit BugBot documentation.

Comment 9

[Petru-Mugurel Lingurar [:petru]]

Small loss of functionality in while the feature is slowly rolled out to beta/release while already in the RC week.
Avoiding the uplift.