1982650 - improve `primary-dependency` finding

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[[e-mail] (:bhearsum)]

Upstream taskgraph added support for more efficient primary dependency finding, and enables to avoid iterating over all upstream tasks to find it. Picking up this change will get us free wins for from_deps usage. We should also replace primary-dependency-kind with primary-dependency-label in a few places to get the wins there too.

Comment 1

[[e-mail] (:bhearsum)]

Attachment: WIP: Bug 1982650: replace me with proper taskgraph upgrade

Comment 2

[[e-mail] (:bhearsum)]

Attachment: WIP: Bug 1982650: replace me with proper taskgraph upgrade

Comment 3

[[e-mail] (:bhearsum)]

Attachment: Bug 1982650: use `primary-dependency-label` in `repackage-rpm` r?#taskgraph-reviewers!

This allows the name_sanity transform to cheaply find the upstream task to copy metadata from. Task payloads are unaffected by this change.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5ccb8db08698
https://hg.mozilla.org/integration/autoland/rev/1a21f8680f4b
use `primary-dependency-label` in `repackage-rpm` r=taskgraph-reviewers,ahal

Comment 5

[agoloman]

Backed out for causing mochitest failures @test_2_conformance2__extensions__ovr_multiview2.html.

• Backout link
• Push with failures mochitest failures
• Push with failures snap failures
• Failure Log mochitest failures
• Failure Log snap failures

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d8d9969f93b7
https://hg.mozilla.org/integration/autoland/rev/924549b23df2
use `primary-dependency-label` in `repackage-rpm` r=taskgraph-reviewers,ahal

Comment 7

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/924549b23df2

Comment 8

[[e-mail] (:bhearsum)]

(In reply to agoloman from comment #5)

Backed out for causing mochitest failures @test_2_conformance2__extensions__ovr_multiview2.html.

• Backout link
• Push with failures mochitest failures
• Push with failures snap failures
• Failure Log mochitest failures
• Failure Log snap failures

I presume this was not actually the cause of that?

Comment 9

[Julien Cristau [:jcristau]]

Only due to the side effect of rebuilding docker images. See bug 1984380.