1982685 - newtabOhttpImages feature is only available in 143+, making Nightly's newtab incompatible for train-hopping to 142.

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect)

Description

[Mike Conley (:mconley) (:⚙️) (PTO June 8 - 12)]

This was an oversight on my part when reviewing bug 1977619, but is causing our nt-trainhop jobs to fail in automation (example)

The solution here, I think, is to use the generic feature json blob feature that we added for train-hops instead.

Comment 1

[Mike Conley (:mconley) (:⚙️) (PTO June 8 - 12)]

Actually, I think the solution is simpler. We'd never want to set the newtabOhttpImages feature on 142, since the moz-cached-ohttp protocol was only introduced in 143. So the simpler solution here is to only read / listen for changes to the newtabOhttpImages feature if it exists.

Comment 2

[Mike Conley (:mconley) (:⚙️) (PTO June 8 - 12)]

Attachment: Bug 1982685 - Add compatibility checks before accessing newtabOhttpImages Nimbus feature to fix newtab trainhop jobs. r?thecount!

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1977619

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/65520f9abd8e
https://hg.mozilla.org/integration/autoland/rev/45715cf86828
Add compatibility checks before accessing newtabOhttpImages Nimbus feature to fix newtab trainhop jobs. r=thecount,home-newtab-reviewers

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/45715cf86828