1982714 - ./mach perftest-test fails on python >= 3.11

Status: NEW

(Testing :: mozperftest, defect, P3)

Description

[Kash Shampur [:kshampur] ⌚EST]

example of failing output

=> linters No partials defined! Bouncer submission task won't send any partial-related entry for "devedition"
No partials defined! Bouncer submission task won't send any partial-related entry for "firefox"
No bouncer entries defined in bouncer submission task for "firefox". Job deleted.
[OK]
=> remove old coverage data [OK]
=> running tests ============================= test session starts ==============================
platform darwin -- Python 3.12.8, pytest-7.0.1, pluggy-1.6.0
rootdir: /Users/shampka/firefox3/python/mozperftest
collected 274 items

python/mozperftest/mozperftest/tests/test_alert.py (<mozperftest.layers.Layers object at 0x113e46090>, 'Running alert:teardown').(<mozperftest.layers.Layers object at 0x113d77830>, 'Running alert:teardown').(<mozperftest.layers.Layers object at 0x113e6bb00>, 'Running alert:teardown').(<mozperftest.layers.Layers object at 0x113e60590>, 'Running alert:teardown').(<mozperftest.layers.Layers object at 0x113e57500>, 'Running alert:teardown').(<mozperftest.layers.Layers object at 0x10279d1f0>, 'Running alert:teardown').(<mozperftest.layers.Layers object at 0x113ebd490>, 'Running alert:teardown').(<mozperftest.layers.Layers object at 0x113ed56a0>, 'Running alert:teardown').(<mozperftest.layers.Layers object at 0x113ef3b90>, 'Running alert:teardown').(<mozperftest.layers.Layers object at 0x113f169c0>, 'Running alert:teardown').(<mozperftest.layers.Layers object at 0x113eda7b0>, 'Running alert:teardown').(<mozperftest.layers.Layers object at 0x113ebe900>, 'Running alert:teardown').(<mozperftest.layers.Layers object at 0x113e3b4a0>, 'Running alert:teardown').(<mozperftest.layers.Layers object at 0x113e56420>, 'Running alert:teardown').(<mozperftest.layers.Layers object at 0x113e3a9c0>, 'Running alert:teardown').
Failed to obtain tasks from alert due to:
Alert ID: 9000
Status Code: 400
Response Message: <MagicMock name='get().json()' id='4629252096'>


Failed to obtain task info due to:
Task ID: 9000
Status Code: 400
Response Message: <MagicMock name='get().json()' id='4629380848'>

..
python/mozperftest/mozperftest/tests/test_android.py (<mozperftest.layers.Layers object at 0x113ef9310>, 'Running profile:teardown')(<mozperftest.layers.Layers object at 0x113ef9310>, 'Running binary-setup:teardown')(<mozperftest.layers.Layers object at 0x113ef9310>, 'Running android:teardown')(<mozperftest.layers.Layers object at 0x113ef9310>, "Running <MagicMock name='mock().name' id='4629253536'>:teardown").(<mozperftest.layers.Layers object at 0x113ebdb20>, 'Running profile:teardown')(<mozperftest.layers.Layers object at 0x113ebdb20>, 'Running binary-setup:teardown')(<mozperftest.layers.Layers object at 0x113ebdb20>, 'Running android:teardown')(<mozperftest.layers.Layers object at 0x113ebdb20>, "Running <MagicMock name='mock().name' id='4629067728'>:teardown").(<mozperftest.layers.Layers object at 0x113f89910>, 'Running profile:teardown')(<mozperftest.layers.Layers object at 0x113f89910>, 'Running binary-setup:teardown')(<mozperftest.layers.Layers object at 0x113f89910>, 'Running android:teardown')(<mozperftest.layers.Layers object at 0x113f89910>, "Running <MagicMock name='mock().name' id='4630427600'>:teardown")....(<mozperftest.layers.Layers object at 0x114124170>, 'Running profile:teardown')(<mozperftest.layers.Layers object at 0x114124170>, 'Running binary-setup:teardown')(<mozperftest.layers.Layers object at 0x114124170>, 'Running android:teardown')(<mozperftest.layers.Layers object at 0x114124170>, "Running <MagicMock name='mock().name' id='4631847296'>:teardown").{"action": "log", "time": 1755030003724, "thread": "MainThread", "pid": 74152, "source": "mozperftest", "component": "adb", "message": "ADBHost: {'_logger': <mozlog.structuredlog.StructuredLogger object at 0x11417cfe0>, '_verbose': False, '_use_root': True, '_adb_path': 'adb', '_adb_host': None, '_adb_port': None, '_timeout': 300, '_polling_interval': 0.001, '_adb_version': ''}", "level": "DEBUG"}
(<mozperftest.layers.Layers object at 0x114177410>, 'Running profile:teardown')(<mozperftest.layers.Layers object at 0x114177410>, 'Running binary-setup:teardown')(<mozperftest.layers.Layers object at 0x114177410>, 'Running android:teardown')(<mozperftest.layers.Layers object at 0x114177410>, 'Running version-producer:teardown').(<mozperftest.layers.Layers object at 0x114177bc0>, 'Running profile:teardown')(<mozperftest.layers.Layers object at 0x114177bc0>, 'Running binary-setup:teardown')(<mozperftest.layers.Layers object at 0x114177bc0>, 'Running android:teardown')(<mozperftest.layers.Layers object at 0x114177bc0>, "Running <MagicMock name='mock().name' id='4627889136'>:teardown").(<mozperftest.layers.Layers object at 0x113e7e390>, 'Running profile:teardown')(<mozperftest.layers.Layers object at 0x113e7e390>, 'Running binary-setup:teardown')(<mozperftest.layers.Layers object at 0x113e7e390>, 'Running android:teardown')(<mozperftest.layers.Layers object at 0x113e7e390>, "Running <MagicMock name='mock().name' id='4628808816'>:teardown").{"action": "log", "time": 1755030003845, "thread": "MainThread", "pid": 74152, "source": "mozperftest", "component": "adb", "message": "ADBHost: {'_logger': <mozlog.structuredlog.StructuredLogger object at 0x1141bd100>, '_verbose': False, '_use_root': True, '_adb_path': 'adb', '_adb_host': None, '_adb_port': None, '_timeout': 300, '_polling_interval': 0.001, '_adb_version': ''}", "level": "DEBUG"}
(<mozperftest.layers.Layers object at 0x1140f3500>, 'Running profile:teardown')(<mozperftest.layers.Layers object at 0x1140f3500>, 'Running binary-setup:teardown')(<mozperftest.layers.Layers object at 0x1140f3500>, 'Running android:teardown')(<mozperftest.layers.Layers object at 0x1140f3500>, "Running <MagicMock name='mock().name' id='4632318400'>:teardown").(<mozperftest.layers.Layers object at 0x1141d88f0>, 'Running profile:teardown')(<mozperftest.layers.Layers object at 0x1141d88f0>, 'Running binary-setup:teardown')(<mozperftest.layers.Layers object at 0x1141d88f0>, 'Running android:teardown')(<mozperftest.layers.Layers object at 0x1141d88f0>, "Running <MagicMock name='mock().name' id='4632072880'>:teardown").(<mozperftest.layers.Layers object at 0x1142330e0>, 'Running profile:teardown')(<mozperftest.layers.Layers object at 0x1142330e0>, 'Running binary-setup:teardown')(<mozperftest.layers.Layers object at 0x1142330e0>, 'Running android:teardown')(<mozperftest.layers.Layers object at 0x1142330e0>, "Running <MagicMock name='mock().name' id='4632977168'>:teardown").(<mozperftest.layers.Layers object at 0x1142745c0>, 'Running profile:teardown')(<mozperftest.layers.Layers object at 0x1142745c0>, 'Running binary-setup:teardown')(<mozperftest.layers.Layers object at 0x1142745c0>, 'Running android:teardown')(<mozperftest.layers.Layers object at 0x1142745c0>, "Running <MagicMock name='mock().name' id='4633208080'>:teardown").(<mozperftest.layers.Layers object at 0x1142b0c80>, 'Running profile:teardown')(<mozperftest.layers.Layers object at 0x1142b0c80>, 'Running binary-setup:teardown')(<mozperftest.layers.Layers object at 0x1142b0c80>, 'Running android:teardown')(<mozperftest.layers.Layers object at 0x1142b0c80>, "Running <MagicMock name='mock().name' id='4633455664'>:teardown").
python/mozperftest/mozperftest/tests/test_androidlog.py Writing results to /var/folders/qy/jzjfkf_d7kq40kr7cmbgx79w0000gn/T/tmp9t7febel/LogCatstd-output.json
.
python/mozperftest/mozperftest/tests/test_argparser.py F

=================================== FAILURES ===================================
________________________________ test_argparser ________________________________

    def test_argparser():
        parser = PerftestArgumentParser()
        args = ["test_one.js"]
>       res = parser.parse_args(args)

python/mozperftest/mozperftest/tests/test_argparser.py:20: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = PerftestArgumentParser(prog='__main__.py', usage='%(prog)s [options] [test paths]', description=None, formatter_class=<class 'argparse.HelpFormatter'>, conflict_handler='resolve', add_help=True)
args = ['test_one.js'], namespace = None, intermixed = False

    def parse_args(self, args=None, namespace=None, intermixed=False):
        self.parse_helper(args)
        if sys.version_info.minor >= 13 or (
            sys.version_info.minor == 12 and sys.version_info.micro > 7
        ):
>           return super().parse_args(args, namespace, intermixed=intermixed)
E           TypeError: ArgumentParser.parse_args() got an unexpected keyword argument 'intermixed'

python/mozperftest/mozperftest/argparser.py:216: TypeError
============================= slowest 10 durations =============================
0.20s call     mozperftest/tests/test_androidlog.py::test_android_log
0.10s call     mozperftest/tests/test_android.py::test_android
0.05s call     mozperftest/tests/test_android.py::test_android_apk_alias
0.04s call     mozperftest/tests/test_android.py::test_android_failure
0.04s call     mozperftest/tests/test_android.py::test_android_log_adb
0.03s setup    mozperftest/tests/test_alert.py::test_alert_basic_command[alert-summary-awsy.json-expected_command0]
0.02s call     mozperftest/tests/test_alert.py::test_alert_exact_command[alert-summary-mpt-desktop.json-task-info-mpt-desktop.json-expected_commands5-4]
0.02s call     mozperftest/tests/test_android.py::test_android_with_binary
0.02s call     mozperftest/tests/test_android.py::test_android_log_cat
0.02s call     mozperftest/tests/test_alert.py::test_alert_exact_command[alert-summary-mpt-desktop-windows.json-task-info-mpt-desktop-windows.json-expected_commands6-3]
=========================== short test summary info ============================
FAILED python/mozperftest/mozperftest/tests/test_argparser.py::test_argparser
!!!!!!!!!!!!!!!!!!!!!!!!!! stopping after 1 failures !!!!!!!!!!!!!!!!!!!!!!!!!!!
========================= 1 failed, 33 passed in 1.63s =========================

[FAILED]
Error running mach:

    mach perftest-test

The error occurred in the implementation of the invoked mach command.

This should never occur and is likely a bug in the implementation of that
command.
You can invoke ``./mach busted`` to check if this issue is already on file. If it
isn't, please use ``./mach busted file perftest-test`` to report it. If ``./mach busted`` is
misbehaving, you can also inspect the dependencies of bug 1543241.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

AssertionError

  File "/Users/shampka/firefox3/python/mozperftest/mozperftest/mach_commands.py", line 129, in run_tests
    _run_tests(command_context, **kwargs)
  File "/Users/shampka/firefox3/python/mozperftest/mozperftest/mach_commands.py", line 193, in _run_tests
    assert checkout_python_script(
           ^^^^^^^^^^^^^^^^^^^^^^^