Make WebGPU external texture support configurable with a pref and blocklistable
Categories
(Core :: Graphics: WebGPU, task, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox143 | --- | fixed |
People
(Reporter: jnicol, Assigned: jnicol)
References
(Blocks 1 open bug)
Details
Attachments
(1 external file)
Block on non-windows, and have the pref default to off on all platforms for now.
When disabled, ensure the Device.importExternalTexture() IDL is hidden
| Assignee | ||
Comment 1•1 year ago
|
||
Adds pref dom.webgpu.external-texture.enabled, which is false by
default, to control whether external texture support is enabled.
Additionally, adds a gfx blocklist entry which can override the pref to
disable on platforms with known issues. Block on non-Windows for now.
When support is disabled, either via the pref or blocklist, ensure the
Device.importExternalTexture() function is hidden. Add an additional
check to the C++ implementation as a precaution.
When support is enabled, enable the required wgpu feature.
Updated•1 year ago
|
Updated•1 year ago
|
| Assignee | ||
Comment 5•1 year ago
|
||
It seems that in some tests gfxVars aren't necessarily initialized at the time when the bindings are created. So attempting to use [Func=...] with a function that checks the gfxVar crashes. This seems to affect xpcshell tests on linux and android, and geckoview-junit tests on android. this makes sense to me as I can see why they wouldn't necessarily have initialized gfxplatform. But curiously it also seems to affect android mochitests.
In any case I think we can call gfxVars::AllowWebGPUExternalTextureOrDefault() which will return the default of false if gfxvars haven't been initialized. xpcshell and junit tests won't need webgpu, and if this causes an issue for android webgpu mochitests down the line we can deal with that then...
Comment 8•1 year ago
|
||
Backed out for causing build bustages @ gfxPlatform.cpp
Backout link: https://hg.mozilla.org/integration/autoland/rev/b270d0133ee593f14f63d4515b602fba893b9dbc
| Assignee | ||
Comment 9•1 year ago
|
||
Ugh, sorry, I renamed a variable and missed it in the non-nightly #ifdefed code
Comment 10•1 year ago
|
||
Comment 11•1 year ago
|
||
| bugherder | ||
Updated•1 year ago
|
Description
•