Closed Bug 1982866 Opened 1 year ago Closed 1 year ago

Make WebGPU external texture support configurable with a pref and blocklistable

Categories

(Core :: Graphics: WebGPU, task, P1)

task

Tracking

()

RESOLVED FIXED
143 Branch
Tracking Status
firefox143 --- fixed

People

(Reporter: jnicol, Assigned: jnicol)

References

(Blocks 1 open bug)

Details

Attachments

(1 external file)

Block on non-windows, and have the pref default to off on all platforms for now.

When disabled, ensure the Device.importExternalTexture() IDL is hidden

Adds pref dom.webgpu.external-texture.enabled, which is false by
default, to control whether external texture support is enabled.
Additionally, adds a gfx blocklist entry which can override the pref to
disable on platforms with known issues. Block on non-Windows for now.

When support is disabled, either via the pref or blocklist, ensure the
Device.importExternalTexture() function is hidden. Add an additional
check to the C++ implementation as a precaution.

When support is enabled, enable the required wgpu feature.

Assignee: nobody → jnicol
Status: NEW → ASSIGNED
Priority: -- → P1
Pushed by jnicol@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/f2fee9b8b447 https://hg.mozilla.org/integration/autoland/rev/48f74cca9142 Make WebGPU external texture support configurable via a pref and blocklistable. r=webgpu-reviewers,webidl,jimb,smaug
Pushed by agoloman@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/337cd46861d2 https://hg.mozilla.org/integration/autoland/rev/4f442f8777b9 Revert "Bug 1982866 - Make WebGPU external texture support configurable via a pref and blocklistable. r=webgpu-reviewers,webidl,jimb,smaug" for causing mass failures.

Backed out for causing mass failures.

Flags: needinfo?(jnicol)

It seems that in some tests gfxVars aren't necessarily initialized at the time when the bindings are created. So attempting to use [Func=...] with a function that checks the gfxVar crashes. This seems to affect xpcshell tests on linux and android, and geckoview-junit tests on android. this makes sense to me as I can see why they wouldn't necessarily have initialized gfxplatform. But curiously it also seems to affect android mochitests.

In any case I think we can call gfxVars::AllowWebGPUExternalTextureOrDefault() which will return the default of false if gfxvars haven't been initialized. xpcshell and junit tests won't need webgpu, and if this causes an issue for android webgpu mochitests down the line we can deal with that then...

Flags: needinfo?(jnicol)
Pushed by jnicol@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/7b08643650c3 https://hg.mozilla.org/integration/autoland/rev/5d30c3e4d590 Make WebGPU external texture support configurable via a pref and blocklistable. r=webgpu-reviewers,webidl,jimb,smaug
Pushed by smolnar@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/93da9cf40205 https://hg.mozilla.org/integration/autoland/rev/b270d0133ee5 Revert "Bug 1982866 - Make WebGPU external texture support configurable via a pref and blocklistable. r=webgpu-reviewers,webidl,jimb,smaug" for causing build bustages @ gfxPlatform.cpp

Ugh, sorry, I renamed a variable and missed it in the non-nightly #ifdefed code

Flags: needinfo?(jnicol)
Pushed by jnicol@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/25076c928dd3 https://hg.mozilla.org/integration/autoland/rev/18fced523266 Make WebGPU external texture support configurable via a pref and blocklistable. r=webgpu-reviewers,webidl,jimb,smaug
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 143 Branch
Regressions: 1983168
QA Whiteboard: [qa-triage-done-c144/b143]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: