1982941 - Turn on the preference of shape() on all channels

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task)

Description

[Boris Chiou [:boris]]

Turn on the preference, layout.css.basic-shape-shape.enabled, on all channels (and send an intent-to-ship email as well).

Comment 1

[Sebastian Zartner [:sebo]]

Once the pref is flipped, this needs to be documented on MDN. And it's also worth mentioning in the general release notes.

[Why is this notable]: Makes it easier to define arbitrary shapes in CSS.
[Affects Firefox for Android]: yes
[Suggested wording]: Added support for the CSS shape() function, which allows to define responsive free-form shapes in properties that take shapes like clip-path. It has some advantages over the path() function, as it uses standard CSS syntax, supports different CSS units, and allows to use math functions.
[Links (documentation, blog post, etc)]: https://developer.mozilla.org/en-US/docs/Web/CSS/basic-shape/shape

Comment 2

[Sebastian Zartner [:sebo]]

Ah, Boris, what's the difference between this bug and bug 1910328?

Sebastian

Comment 3

[Boris Chiou [:boris]]

(In reply to Sebastian Zartner [:sebo] from comment #2)

Ah, Boris, what's the difference between this bug and bug 1910328?

Sebastian

This extra bug is for the project purpose. We would like to make the feature as a simple project to let the intern work on, and so we would like to make bug 1910328 as the meta bug which includes all the steps to achieve this project (i.e. ship shape() function).

This just makes us easier to do the estimation, manage the project, and assign points to each step.

Sorry for making you confused.

Comment 4

[Swarup Ukil [:sukil]]

Attachment: Bug 1982941 - Enable shape() pref by default on all channels. r=boris

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/99003e227fe9
https://hg.mozilla.org/integration/autoland/rev/a92427adc32d
Enable shape() pref by default on all channels. r=boris

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/a92427adc32d

Comment 7

[Donal Meehan [:dmeehan]]

:sukil/:boris , could you consider nominating this for a release note? (Process info)

Comment 8

[Donal Meehan [:dmeehan]]

nvm, there is already a request from several months ago

Comment 9

[Donal Meehan [:dmeehan]]

Added to the Fx148 nightly release notes, please allow 30 minutes for the site to update.
Keeping the relnote-firefox flag as ? to keep it on the radar for inclusion in the final Fx148 release notes.

Comment 10

[Dave Letorey]

Associated Pull Requests

• BCD PR
• Firefox Release PR

Comment 11

[Donal Meehan [:dmeehan]]

Added to the final Fx148 release notes