1982963 - Collect PSI information in crash reports to study correlation between PSI and oom-killer on Linux

Status: RESOLVED FIXED

(Core :: Performance: Memory, task)

Description

[Thinker Li [:sinker]]

Add a new annotation to crash report in order to collect PSI information when oom-killer kills Firefox.

/proc/pressure/memory provides memory PSI (Pressure Stall Information) of Linux.
We need this information to study the correlation between oom-kill and PSI.
If they are highly related, we should incorporate PSI to AvailableMemoryWatcher for Linux.

Comment 1

[Thinker Li [:sinker]]

Attachment: Bug 1982963 - Add the LinuxMemoryPSI annotation to the crash report.

LinuxMemoryPSI will contain the values from /proc/pressure/memory.
It provides information of memory pressure. [1]

[1] https://docs.kernel.org/accounting/psi.html

Comment 2

[Thinker Li [:sinker]]

Attachment: Bug 1982963 - Test case to make sure LinuxMemoryPSI is in the crash report.

test_crash_psi_annotation.js comprise two test cases. One is for PSI
available, the other one is for PSI unavailable. It make sure
LinuxMemoryPSI works normal with or without PSI.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/77aa63a2127b
https://hg.mozilla.org/integration/autoland/rev/8151b466dad1
Add the LinuxMemoryPSI annotation to the crash report. r=xpcom-reviewers,nika
https://github.com/mozilla-firefox/firefox/commit/a266216a54e3
https://hg.mozilla.org/integration/autoland/rev/63a2c88212c1
Test case to make sure LinuxMemoryPSI is in the crash report. r=xpcom-reviewers,nika

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/234d2b5a25db
https://hg.mozilla.org/integration/autoland/rev/4bea0632667c
Revert "Bug 1982963 - Test case to make sure LinuxMemoryPSI is in the crash report. r=xpcom-reviewers,nika" for causing build bustages in AvailableMemoryWatcherLinux.cpp.

Comment 5

[Serban Stanca [:SerbanS]]

Reverted this because it was causing build bustages in AvailableMemoryWatcherLinux.cpp.

• Revert link
• Push with failures
• Failure Log
• Failure line: /builds/worker/checkouts/gecko/xpcom/base/AvailableMemoryWatcherLinux.cpp:X:27: error: result of comparison of unsigned expression < 0 is always false [-Werror,-Wtautological-unsigned-zero-compare]

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a87ad8d89c66
https://hg.mozilla.org/integration/autoland/rev/ba800c99bdff
Revert "Bug 1982963 - Add the LinuxMemoryPSI annotation to the crash report. r=xpcom-reviewers,nika" for causing build bustages in AvailableMemoryWatcherLinux.cpp.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1c8cafec146a
https://hg.mozilla.org/integration/autoland/rev/099c25271a4a
Add the LinuxMemoryPSI annotation to the crash report. r=xpcom-reviewers,nika
https://github.com/mozilla-firefox/firefox/commit/9acc6af34eb1
https://hg.mozilla.org/integration/autoland/rev/4aeb204720fd
Test case to make sure LinuxMemoryPSI is in the crash report. r=xpcom-reviewers,nika
https://github.com/mozilla-firefox/firefox/commit/296990a936ac
https://hg.mozilla.org/integration/autoland/rev/14cef31ea0f5
apply code formatting via Lando

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/099c25271a4a
https://hg.mozilla.org/mozilla-central/rev/4aeb204720fd
https://hg.mozilla.org/mozilla-central/rev/14cef31ea0f5