1983051 - Intermittent [TV] browser/components/customizableui/test/browser_palette_labels.js | history-panelmenu should have at least one visible icon. - 0 > 0 -

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: smolnar [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=522360397&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/MizBmXirQxKD9U48ik4VBw/runs/0/artifacts/public/logs/live_backing.log
Reftest URL: https://hg.mozilla.org/mozilla-central/raw-file/default/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/MizBmXirQxKD9U48ik4VBw/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

---

INFO - TEST-PASS | browser/components/customizableui/test/browser_palette_labels.js | history-panelmenu has a label. - 
[task 2025-08-14T11:52:40.480+00:00] 11:52:40     INFO - Buffered messages finished
[task 2025-08-14T11:52:40.480+00:00] 11:52:40     INFO - TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_palette_labels.js | history-panelmenu should have at least one visible icon. - 0 > 0 - 
[task 2025-08-14T11:52:40.481+00:00] 11:52:40     INFO - Stack trace:
[task 2025-08-14T11:52:40.481+00:00] 11:52:40     INFO - chrome://mochitests/content/browser/browser/components/customizableui/test/browser_palette_labels.js:test_all_buttons_have_labels:66
[task 2025-08-14T11:52:40.482+00:00] 11:52:40     INFO - chrome://mochikit/content/browser-test.js:handleTask:1238
[task 2025-08-14T11:52:40.482+00:00] 11:52:40     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1327
[task 2025-08-14T11:52:40.483+00:00] 11:52:40     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1474
[task 2025-08-14T11:52:40.483+00:00] 11:52:40     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1214
[task 2025-08-14T11:52:40.483+00:00] 11:52:40     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
[task 2025-08-14T11:52:40.484+00:00] 11:52:40     INFO - TEST-PASS | browser/components/customizableui/test/browser_palette_labels.js | save-page-button has a label. - 
[task 2025-08-14T11:52:40.484+00:00] 11:52:40     INFO - Not taking screenshot here: see the one that was previously logged
[task 2025-08-14T11:52:40.485+00:00] 11:52:40     INFO - TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_palette_labels.js | save-page-button should have at least one visible icon. - 0 > 0 - 
[task 2025-08-14T11:52:40.486+00:00] 11:52:40     INFO - Stack trace:
[task 2025-08-14T11:52:40.487+00:00] 11:52:40     INFO - chrome://mochitests/content/browser/browser/components/customizableui/test/browser_palette_labels.js:test_all_buttons_have_labels:66
[task 2025-08-14T11:52:40.488+00:00] 11:52:40     INFO - chrome://mochikit/content/browser-test.js:handleTask:1238
[task 2025-08-14T11:52:40.489+00:00] 11:52:40     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1327
[task 2025-08-14T11:52:40.489+00:00] 11:52:40     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1474
[task 2025-08-14T11:52:40.489+00:00] 11:52:40     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1214
[task 2025-08-14T11:52:40.490+00:00] 11:52:40     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
[task 2025-08-14T11:52:40.493+00:00] 11:52:40     INFO - TEST-PASS | browser/components/customizableui/test/browser_palette_labels.js | print-button has a label. - 
[task 2025-08-14T11:52:40.494+00:00] 11:52:40     INFO - Not taking screenshot here: see the one that was previously logged
[task 2025-08-14T11:52:40.494+00:00] 11:52:40     INFO - TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_palette_labels.js | print-button should have at least one visible icon. - 0 > 0 - 
[task 2025-08-14T11:52:40.494+00:00] 11:52:40     INFO - Stack trace:
[task 2025-08-14T11:52:40.495+00:00] 11:52:40     INFO - chrome://mochitests/content/browser/browser/components/customizableui/test/browser_palette_labels.js:test_all_buttons_have_labels:66
[task 2025-08-14T11:52:40.495+00:00] 11:52:40     INFO - chrome://mochikit/content/browser-test.js:handleTask:1238
[task 2025-08-14T11:52:40.496+00:00] 11:52:40     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1327
[task 2025-08-14T11:52:40.496+00:00] 11:52:40     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1474
[task 2025-08-14T11:52:40.496+00:00] 11:52:40     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1214
[task 2025-08-14T11:52:40.497+00:00] 11:52:40     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
[task 2025-08-14T11:52:40.498+00:00] 11:52:40     INFO - TEST-PASS | browser/components/customizableui/test/browser_palette_labels.js | find-button has a label. - 
[task 2025-08-14T11:52:40.499+00:00] 11:52:40     INFO - TEST-PASS | browser/components/customizableui/test/browser_palette_labels.js | find-button should have at least one visible icon. - 1 > 0 - 
[task 2025-08-14T11:52:40.501+00:00] 11:52:40     INFO - TEST-PASS | browser/components/customizableui/test/browser_palette_labels.js | open-file-button has a label. - 
[task 2025-08-14T11:52:40.501+00:00] 11:52:40     INFO - Not taking screenshot here: see the one that was previously logged
[task 2025-08-14T11:52:40.501+00:00] 11:52:40     INFO - TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_palette_labels.js | open-file-button should have at least one visible icon. - 0 > 0 - 
[task 2025-08-14T11:52:40.502+00:00] 11:52:40     INFO - Stack trace:
[task 2025-08-14T11:52:40.502+00:00] 11:52:40     INFO - chrome://mochitests/content/browser/browser/components/customizableui/test/browser_palette_labels.js:test_all_buttons_have_labels:66
[task 2025-08-14T11:52:40.502+00:00] 11:52:40     INFO - chrome://mochikit/content/browser-test.js:handleTask:1238
[task 2025-08-14T11:52:40.502+00:00] 11:52:40     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1327

Comment 1

[BugBot [:suhaib / :marco]]

:dao, since you are the author of the regressor, bug 1975009, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[Dão Gottwald [:dao]]

I confirmed locally that this test failed without my patch when run on its own or in verify mode, my patch just exposed it again on automation by touching the test file.

Comment 3

[Intermittent Failures Robot]

11 failures were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 9
• mozilla-central: 2

Table

	no_variant
linux1804-x86_64/tsan	1
linux2404-x86_64/ccov	1
linux2404-x86_64/debug	1
linux2404-x86_64/opt	1
macosx1470-x86_64/debug	1
macosx1470-x86_64/opt	1
windows11-x86/debug	1
windows11-x86/opt	1
windows11-x86_64/ccov	1
windows11-x86_64/debug	1
windows11-x86_64/opt	1

For more details, see:

https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1983051&startday=2025-08-11&endday=2025-08-17&tree=all

Comment 4

[Florian Quèze [:florian]]

Attachment: Bug 1983051 - Fix browser_palette_labels.js standalone failure by waiting for icons to paint, r=Gijs.

Comment 5

[Florian Quèze [:florian]]

The test had a race condition in its wait logic - it waited for ANY icon to be visible (.length > 0), then immediately checked ALL icons. This caused standalone failures because at startup, only 5/33 icons were painted by the time the wait condition passed.

The fix changes the wait condition to ensure all icons with non-zero width also have non-zero height before proceeding. This waits for the images to load and paint (~50ms) rather than checking icons as soon as the first one is ready.

This was perma fail when running the test alone and passed when running the entire manifest because previous tests "warm up" the system, making icons paint much faster.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/65428661586a
https://hg.mozilla.org/integration/autoland/rev/5a116fb81f9a
Fix browser_palette_labels.js standalone failure by waiting for icons to paint, r=Gijs.

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/5a116fb81f9a