Add group/row label to VPN and market suggestions
Categories
(Firefox :: Address Bar, task, P2)
Tracking
()
People
(Reporter: adw, Unassigned)
References
Details
(Whiteboard: [sng])
We need to stop setting hideRowLabel: true for VPN and market suggestions and all upcoming carrots/realtime suggestions, per Nive. They should always show their group label.
VPN suggestions set hideRowLabel in their RS data. Market suggestions set it in the code. I don't believe there are any other dynamic Rust suggestions that set it in their RS data.
Important-dates suggestions also set it, and they are considered best matches in the code, but hiding the label is correct for them. Nive says they should be considered more as utility suggestions than Suggest suggestions. We should maybe stop setting isBestMatch on them and instead just set suggestedIndex directly. IIRC that will cause UrlbarView.#rowLabel() to return null for them, and then we can remove hideRowLabel on them.
If we don't need to hide the row label for any suggestions anymore, then we should get rid of hideRowLabel too. That can be a follow-up.
|
||
Updated•10 months ago
|
|
Reporter | |
Comment 1•10 months ago
|
||
Uncoupling this from bug 1967316 since this is not a blocker.
|
|
Reporter | |
Comment 2•5 months ago
|
||
Change in plans, see bug 2010177.
Description
•