Print preview doesn't show some pages when printing a pdf
Categories
(Core :: Print Preview, defect, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr128 | --- | unaffected |
| firefox-esr140 | --- | unaffected |
| firefox141 | --- | unaffected |
| firefox142 | --- | unaffected |
| firefox143 | + | verified |
| firefox144 | --- | verified |
People
(Reporter: calixte, Assigned: emilio)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file, 1 external file)
|
992.50 KB,
application/pdf
|
Details |
STR:
- open the pdf
- print it
In the print preview, the four first pages are empty and when scrolling back to the first one then the first page is rendered correctly.
Some pages are partially rendered.
In using mozregression, I found that this regression is because of bug 1981748.
Comment 1•1 year ago
|
||
Set release status flags based on info from the regressing bug 1981748
| Assignee | ||
Comment 2•1 year ago
|
||
[Tracking Requested - why for this release]: PDF print preview regression
| Assignee | ||
Comment 3•1 year ago
|
||
Just to confirm, this is just about the print preview right? Does printing (well, saving to pdf) produce the right output?
| Assignee | ||
Updated•1 year ago
|
| Reporter | ||
Comment 4•1 year ago
|
||
Yep it's just about the preview: saving to pdf is fine.
| Assignee | ||
Comment 5•1 year ago
|
||
After bug 1981748, display items have the page number stored in the
per-frame key when printing.
This code was assuming that the per-frame key was just the display item
type, which is an assumption that no longer holds.
Invalidate all the relevant display items. I think this might have been
a pre-existing issue, if you had a canvas that could overflow into the
next page. However I believe to hit this you need mozPrintCallback so
maybe we just never hit this...
Not sure how to write a test given the need for mozPrintCallback, but
can try...
Updated•1 year ago
|
| Assignee | ||
Updated•1 year ago
|
Updated•1 year ago
|
Comment 7•1 year ago
|
||
| bugherder | ||
Comment 9•1 year ago
|
||
The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?
- If yes, please nominate the patch for beta approval.
- See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
- If no, please set
status-firefox143towontfix.
For more information, please visit BugBot documentation.
| Assignee | ||
Comment 10•1 year ago
|
||
Comment on attachment 9507540 [details]
Bug 1983147 - Fix WebRender canvas content invalidation when printing. r=tnikkel
Beta/Release Uplift Approval Request
- User impact if declined/Reason for urgency: Regression in pdf print preview.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: comment 0
- List of other uplifts needed: none
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Worst case we over-invalidate.
- String changes made/needed: none
- Is Android affected?: Yes
| Assignee | ||
Updated•1 year ago
|
Comment 11•1 year ago
|
||
Comment on attachment 9507540 [details]
Bug 1983147 - Fix WebRender canvas content invalidation when printing. r=tnikkel
Approved for 143.0b3.
Updated•1 year ago
|
Comment 12•1 year ago
|
||
| uplift | ||
Updated•1 year ago
|
Updated•1 year ago
|
Comment 13•1 year ago
|
||
Reproduced the issue on an affected Nightly build from 2025-08-14.
Verified as fixed on the latest Nightly 144.0a1 (20250824214058) and Beta 143.0b3 (20250822090535) using Windows 10, Ubuntu 22, and macOS 13. In these builds, the problem is no longer reproducible:
- All pages are rendered correctly in print preview.
- No empty or partially rendered pages appear when scrolling through the preview.
Marking the issue as verified fixed.
Description
•