Closed Bug 1983567 Opened 2 months ago Closed 1 month ago

Create a new Terms of Use onboarding card based on the new design for Portrait mode.

Categories

(Firefox for Android :: Onboarding, task, P2)

Product:
Firefox for Android
Component:
Onboarding
Platform:
All
Android
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
144 Branch
Tracking Flags:
Tracking Status
firefox144 --- fixed

People

(Reporter: towhite, Assigned: towhite)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [fxdroid][group2])

Attachments

(3 files)

Bug 1983567 - Part 1: Refactor new line spacing in the onboarding strings to separate each 'page' type.
48 bytes, text/x-phabricator-request
Details | Review
Bug 1983567 - Part 2: Add the required new strings for the terms of use onboarding page
48 bytes, text/x-phabricator-request
Details | Review
Bug 1983567 - Part 3: Update the TermsOfServiceOnboardingPageRedesign.kt to match the new design
48 bytes, text/x-phabricator-request
Details | Review

Use the existing Terms of Use onboarding card as a base to work from.

  • Add required image asset
  • Ensure sizing with implementation
  • Add image asset to keep.xml to prevent it from being obfuscated
  • Update the preview text to use the new copy

Expected UI elements:

  • Icon
  • Title
  • Subtitle 1*
  • Subtitle 2*
  • Subtitle 3*
  • Caption 1
  • Caption 2
  • Caption 3
  • Button

*Will also require additional Nimbus fields:
Subtitle 1
Subtitle 2
Subtitle 3

These should be added in the TermsOfServiceData object defined in onboarding.fml.yaml .

This covers Phone & Min size.

Summary: Update the existing imagery for use in each card where possible → Add the redesigned imagery for use in each card where possible
Summary: Add the redesigned imagery for use in each card where possible → Create a new Terms of Use onboarding card based on the new design.
Summary: Create a new Terms of Use onboarding card based on the new design. → Create a new Terms of Use onboarding card based on the new design for Portrait mode.
Blocks: 1985322
Assignee: nobody → towhite
Attachment #9510790 - Attachment description: WIP: Bug 1983567 - Part 3: Update the TermsOfServiceOnboardingPageRedesign.kt to match the new design → Bug 1983567 - Part 3: Update the TermsOfServiceOnboardingPageRedesign.kt to match the new design
Pushed by icedicedcoffee@proton.me: https://github.com/mozilla-firefox/firefox/commit/2f4806f49562 https://hg.mozilla.org/integration/autoland/rev/5b0dd3b2f905 Part 1: Refactor new line spacing in the onboarding strings to separate each 'page' type. r=android-reviewers,android-l10n-reviewers,flod,rebecatudor273

https://hg.mozilla.org/mozilla-central/rev/5b0dd3b2f905

Status: NEW → RESOLVED
Closed: 1 month ago
status-firefox144: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 144 Branch
Pushed by icedicedcoffee@proton.me: https://github.com/mozilla-firefox/firefox/commit/e587356e2bed https://hg.mozilla.org/integration/autoland/rev/4a4b3361db32 Part 2: Add the required new strings for the terms of use onboarding page r=android-reviewers,android-l10n-reviewers,flod,rebecatudor273 https://github.com/mozilla-firefox/firefox/commit/fb91abc5adb6 https://hg.mozilla.org/integration/autoland/rev/f23cfcdc2080 Part 3: Update the TermsOfServiceOnboardingPageRedesign.kt to match the new design r=android-reviewers,gmalekpour
Depends on: 1993467
Regressions: 1995812
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: