1983692 - Add ToU onboarding check for official builds

Status: RESOLVED DUPLICATE of bug 1990983

(Firefox :: Messaging System, task, P2)

Description

[Chris Peterson [:cpeterson]]

Meg added a compile-time check so developers' local builds didn't show them the ToU onboarding prompt every time they test their code. The check turns off the termsofuse.bypassNotification pref (in bug 1964544) for MOZILLA_OFFICIAL builds.

However, some Linux distros build Firefox with MOZILLA_OFFICIAL enabled to get the official Firefox branding and icons. Firefox doesn't need to show the ToU onboarding in non-Mozilla builds, so we should investigate how to check for Mozilla official builds separately from MOZILLA_OFFICIAL.

Comment 1

[Vtay]

We can’t rely on MOZILLA_OFFICIAL or “app.update.channel” pref == “release because distros’ builds.

It seems the most feasible path forward is to target by distribution IDs.
https://firefox-source-docs.mozilla.org/browser/components/asrouter/docs/targeting-attributes.html#distributionid

We can tell our flat pack and deb from their unique distribution IDs. The lack of a distribution ID seems to point to our official build because most Linux distros put a distribution ID in.

We should investigate if this is possible.

Comment 2

[Mimi Jung]

Will be addressed with 1990983