198375 - Add "Accel+0" to menu entry for Text Zoom 100%

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Prognathous]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.3) Gecko/20030312
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.3) Gecko/20030312

The shortcut to reset Text Zoom to 100% is missing from View -> Text Zoom menu.
This affects both in Browser and Mail&News.
The text "(Original Size)" should be replaced by "Accel+0".

An open issue is which mnemonic to choose instead of &z. Both &1 and &0 are
already used by other entries and the only one left is &% (this is one reason
why the parenthesized text was added in the first place).
A possible compromise could be: "100% (&Reset) Accel+0"

Reproducible: Always

Steps to Reproduce:




For more details see Bug 198369 and Bug 69565

Comment 1

[Aaron Leventhal]

Spark, is this a good one for you to take?

Comment 2

[piers]

-> Me.

Comment 3

[piers]

Attachment: Show the shortcut key on the menu item

Comment 4

[Alec Flett]

Comment on attachment 118049 [details] [diff] [review]
Show the shortcut key on the menu item

sr=alecf

Comment 5

[:deanis74]

Comment on attachment 118049 [details] [diff] [review]
Show the shortcut key on the menu item

+      menuItem.setAttribute("key","key_textZoomReset");

Space after the comma, please.	r=me

Comment 6

[piers]

Attachment: Show the shortcut key on the menu item v2

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in mozilla/xpfe/communicator/resources/content/viewZoomOverlay.js;
/cvsroot/mozilla/xpfe/communicator/resources/content/viewZoomOverlay.js,v  <-- 
viewZoomOverlay.js
new revision: 1.8; previous revision: 1.7
done
Checking in mozilla/xpfe/communicator/resources/content/viewZoomOverlay.xul;
/cvsroot/mozilla/xpfe/communicator/resources/content/viewZoomOverlay.xul,v  <--
 viewZoomOverlay.xul
new revision: 1.10; previous revision: 1.9
done

Comment 8

[Prognathous]

First, thanks for fixing this.

Second, it would be clearer, IMHO, to follow Aaron Leventhal's suggestion in Bug
198369: "No zoom (100%)". This instead of using "100% Original Size" as
implemented by this patch.

If this bug is reopened, it should block the other one. The documentation should
reflect the way entries are displayed in the menus.

Prog.

Comment 9

[Prognathous]

Correction: the current menu entry is "100% (Original Size)" with a parenthesis.

Sorry for the spam,

Prog.