1983881 - on the new android 14 emulator in Ci, gtest cubeb.test_output_callback is failing very frequently

Status: RESOLVED FIXED

(Core :: Audio/Video: cubeb, defect, P1)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

as seen on this try push, you see see this failure:

[task 2025-08-19T16:14:41.779+00:00] 16:14:41     INFO -  TEST-PASS | cubeb.test_input_callback | test completed (time: 2ms)
[task 2025-08-19T16:14:41.779+00:00] 16:14:41     INFO -  TEST-START | cubeb.test_output_callback
[task 2025-08-19T16:15:02.088+00:00] 16:15:02  WARNING -  TEST-UNEXPECTED-FAIL | cubeb.test_output_callback | Expected equality of these values:
[task 2025-08-19T16:15:02.088+00:00] 16:15:02     INFO -    user_state.error_state
[task 2025-08-19T16:15:02.088+00:00] 16:15:02     INFO -      Which is: 0
[task 2025-08-19T16:15:02.088+00:00] 16:15:02     INFO -    1
[task 2025-08-19T16:15:02.088+00:00] 16:15:02     INFO -  Callback expected error state
[task 2025-08-19T16:15:02.088+00:00] 16:15:02     INFO -   @ /builds/worker/checkouts/gecko/media/libcubeb/test/test_callback_ret.cpp:221
[task 2025-08-19T16:15:02.088+00:00] 16:15:02  WARNING -  TEST-UNEXPECTED-FAIL | cubeb.test_output_callback | test completed (time: 474ms)

I don't know if there is an easy way to skip this specific test, I assume something like #ifndef Android .... I will figure out a way to skip only this specific test and submit a patch for that- otherwise we will not have gtest coverage on android emulator come September 15th.

Comment 1

[Paul Adenot (:padenot)]

it's likely a bug in the implem.

Comment 2

[Paul Adenot (:padenot)]

Joel, how can I make a push like yours? I wanted to add debugging code.

I have the following:

./mach try fuzzy --no-artifact --rebuild 3 -q "test-android-em-14 \!windows \!macosx \!em-7 \!-hw-"
Creating the 'try' site at /Users/padenot/.mozbuild/srcdirs/firefox-180c0a27f5c2/_virtualenvs/try
Task configuration changed, generating target task set
no tasks selected

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

code was just landed yesterday, it is merged to central already. Searchfox isn't updated, but you need to uncomment out gtest here:
https://hg-edge.mozilla.org/integration/autoland/rev/11f0d1bf4665#l11.12
^ it was commented out in a followup commit

the ./mach ... command looks almost right, I would add gtest to the query :)

Comment 4

[Paul Adenot (:padenot)]

https://treeherder.mozilla.org/jobs?repo=try&landoCommitID=148521 with some debugging code

Comment 5

[Paul Adenot (:padenot)]

Sorry, https://treeherder.mozilla.org/jobs?repo=try&revision=1a38578159f38b58731e5ddb070541e98c44ddd3

Comment 6

[Paul Adenot (:padenot)]

Sorry sorry, https://treeherder.mozilla.org/jobs?repo=try&landoCommitID=148637, with the gtest uncommented as you said

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

looking at the try push ^, it is still failing. In 3 weeks we will be turning off the android 7 tests.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:kinetik, could you have a look please?

For more information, please visit BugBot documentation.

Comment 9

[Paul Adenot (:padenot)]

https://treeherder.mozilla.org/jobs?repo=try&landoCommitID=151023

Comment 10

[Paul Adenot (:padenot)]

Matthew, can you look at https://hg-edge.mozilla.org/try/rev/10d1882779042658539f6862b350f7bb7442bb4c, and see if there's a hole? I'm a bit surprised it doesn't fix it.

Comment 11

[Matthew Gregan [:kinetik]]

(In reply to Paul Adenot (:padenot) from comment #10)

Matthew, can you look at https://hg-edge.mozilla.org/try/rev/10d1882779042658539f6862b350f7bb7442bb4c, and see if there's a hole? I'm a bit surprised it doesn't fix it.

Seems reasonable to me... but it looks like the state thread still isn't passing updates back. I'll poke around a bit more since I'm already working on other bugs in this code.

Comment 12

[Joel Maher ( :jmaher ) (UTC -8)]

in 1 week (sept 15th), gtest on android 7 will be turned off. Is this going to be resolved, or should we disable the failing test and enable gtest for android 14?

Comment 13

[Matthew Gregan [:kinetik]]

I'm hoping to have a fix before then, I'll have a patch ready in a day or so.

Comment 14

[Matthew Gregan [:kinetik]]

https://treeherder.mozilla.org/jobs?repo=try&revision=67892287d94a5c54802a2118d0a07533c2520a58

Comment 15

[Matthew Gregan [:kinetik]]

Attachment: GitHub Pull Request

Comment 16

[Matthew Gregan [:kinetik]]

Attachment: Bug 1983881 - Update libcubeb to 19994eb29cfe4f7347eda3be2f14775e964a2471. r?#cubeb-reviewers

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ccc7df730518
https://hg.mozilla.org/integration/autoland/rev/91aa7324f01f
Update libcubeb to 19994eb29cfe4f7347eda3be2f14775e964a2471.  r=cubeb-reviewers,pehrsons

Comment 18

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/91aa7324f01f

Comment 19

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: Bug 1983881 - turn on gtest for android 14. r=aryx

Comment 20

[Joel Maher ( :jmaher ) (UTC -8)]

forgot to turn the test on!

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0f9eb6be2621
https://hg.mozilla.org/integration/autoland/rev/1b52a9a67118
turn on gtest for android 14. r=jcristau

Comment 22

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/1b52a9a67118