1983967 - Remove obsolete references to browser.privatebrowsing.vpnpromourl

Status: RESOLVED FIXED

(Firefox :: Messaging System, task, P3)

Description

[Rob Wu [:robwu]]

Bug 1754832 removed the only use of browser.privatebrowsing.vpnpromourl, but there are still references to it in the tree. These can be removed:

• https://searchfox.org/firefox-main/rev/60308bc3792ef201b82377682de068a5a1c72575/toolkit/modules/RemotePageAccessManager.sys.mjs#133-136
• https://searchfox.org/firefox-main/rev/60308bc3792ef201b82377682de068a5a1c72575/browser/app/profile/firefox.js#852-854

This to-do was called out at https://phabricator.services.mozilla.com/D140565#anchor-inline-777663, but there was never a bug filed for it. There is also a callout to retaining the functionality for scenarios that desire the removal of the promotion in certain regions (bug 1664360), and it looks like the mentioned shouldShowVPNPromo method is still working today (config). So in other words, other than the removal of the lines referenced above, there is no action item left.

Comment 1

[Mimi Jung]

Ni'ing Punam.

Comment 2

[Punam Dahiya [:pdahiya]]

Attachment: Bug 1983967 - Remove obsolete references to browser.privatebrowsing.vpnpromourl

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/769e2f4d58dd
https://hg.mozilla.org/integration/autoland/rev/c3bf5d73e941
Remove obsolete references to browser.privatebrowsing.vpnpromourl r=robwu

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/c3bf5d73e941