1983984 - Dynamic UrlbarView rows can end up with "undefined" in their CSS classes

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[Drew Willcoxon :adw]

I was debugging some CSS for market suggestions and found that the view can end up setting CSS classes called urlbarView-dynamic-${dynamicType}-undefined on elements in dynamic rows. It happens here when the childTemplate object doesn't have a name. The jsdoc says that name is required, but that's not enforced anywhere, so it's easy to miss, and I don't think it actually needs to be required at all.

This doesn't have any noticeable effects AFAICT -- seems to be harmless.

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1983984 - Let `name` be optional on urlbar dynamic view templates.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/095a0bd92a87
https://hg.mozilla.org/integration/autoland/rev/12f186d30498
Let `name` be optional on urlbar dynamic view templates. r=daisuke

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/12f186d30498

Comment 4

[Drew Willcoxon :adw]

Attachment: Bug 1983984 - Let `name` be optional on urlbar dynamic view templates.

Original Revision: https://phabricator.services.mozilla.com/D261680

Comment 5

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: This is required for the "carrots" realtime-suggestions Suggest feature in 143.
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: none
• Risk associated with taking this patch: low
• Explanation of risk level: This isn't a user-visible change and is just a fix for harmless logical error.
• String changes made/needed: none
• Is Android affected?: no

Comment 6

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/64bcf0df1f0c
https://hg.mozilla.org/releases/mozilla-beta/rev/0333a6c76203