Closed Bug 1984041 Opened 1 year ago Closed 11 months ago

Update existing DOM storage instrumentation to use gecko-trace component

Categories

(Core :: Storage: Quota Manager, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
145 Branch
Tracking Status
firefox145 --- fixed

People

(Reporter: michael, Assigned: michael)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

With the new collection system in place, the currently active QM_TRY error handling needs to be extended with the new gecko-trace component.

This corresponds to FFXP-3026 the last item of FFXP-2930.

This patch extends the existing instrumentation in the DOM storage components to
use the new gecko-trace tracing component.

It does so by inserting Spans at the start of common operations and updating the
LogError function in QuotaCommon.cpp to emit a SpanEvent.

The instrumentation currently exists alongside the Glean-based events. The Glean
event metric will remain in place until the new system has been proven to work
and telemetry integrations are available.

Attachment #9508099 - Attachment description: Bug 1984041 - Extend DOM storage instrumentation with gecko-trace component r=janv → WIP: Bug 1984041 - Extend DOM storage instrumentation with gecko-trace component r=janv
Attachment #9508099 - Attachment description: WIP: Bug 1984041 - Extend DOM storage instrumentation with gecko-trace component r=janv → Bug 1984041 - Extend DOM storage instrumentation with gecko-trace component r=janv
Pushed by mvanstraten@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/841bcf6fb644 https://hg.mozilla.org/integration/autoland/rev/b112df599ecc Extend DOM storage instrumentation with gecko-trace component r=janv,dom-storage-reviewers,dom-worker-reviewers,edenchuang
Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → 145 Branch
QA Whiteboard: [qa-triage-done-c146/b145]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: