1984045 - Firefox 142.0+Windows Magnifier=problem

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Hugo Simões]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:142.0) Gecko/20100101 Firefox/142.0

Steps to reproduce:

Firefox updated from 141.0.3 to Firefox 142.0. I thought the problem was an addon I instaleld the same day prior to Firefox update. Once I disabled the addon, I realizeed that the problem was with Firefox. I tried to downgrade to Firefox 141.0.3.. The problem is that I used Magnifier whole time and when I used Youtube chat, the focus of text was over the video instead of the text zone where I was typing. It also happens where is a text box. I had to disable 2 options in Magnifer to write this.

Actual results:

Text focus is wrong when I'm typing text with Magnifier is turned on and Text focus/follow cursor is on.

Expected results:

The normal behaviour... the focus should follow the text cursor on Firefox.

Comment 1

[Hugo Simões]

With Magnifer enabled + Focus on text/Follow cursor and we type somewhere on Firefox, the focus goes somewhere else. The focus goes to right when ype text but it is not pointing at that right zone where the text is being typed. It is really annoying and it started to happen with Firefox 142.0.

Comment 2

[Dianna Smith [:diannaS]]

I fpossible, do you think you could you run mozregression? Might help us identify the culprit.

Comment 3

[James Teh [:Jamie]]

Possibly related to bug 1966812 or bug 1977544. We've yet to reproduce the bug, though.

Comment 4

[James Teh [:Jamie]]

Hugo, do you have the title bar enabled in Firefox (right click the toolbar, choose Customize Toolbar, check whether "Title Bar" is checked)? We haven't been able to reproduce this yet, so we're still trying to gather possibly relevant information. Thanks.

Comment 5

[James Teh [:Jamie]]

We weren't able to reproduce this with Magnifier, but I do see that the caret rectangle is incorrect in 142, so I'm going to assume for now that this is what is causing the problem.

3:03.61 INFO: Last good revision: c26a266873030a7d9a0a663eec2c54bb69c6ac76
3:03.61 INFO: First bad revision: 23ff9b5bff9f84cc89b076642c4f7a6f49ac7b57
3:03.61 INFO: Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=c26a266873030a7d9a0a663eec2c54bb69c6ac76&tochange=23ff9b5bff9f84cc89b076642c4f7a6f49ac7b57

That implicates bug 1977544. However, this appears to be fixed in Nightly, so I'd like to work out why that is. I suspect it was fixed by bug 1976137, but I don't quite understand why yet.

Comment 6

[James Teh [:Jamie]]

The fix was:

5:51.84 INFO: First good revision: e70925dcdcd7352b71ee8f879a963ab097afb04c
5:51.84 INFO: Last bad revision: 6e9a94a466714b4d469cc06bff2ccc0698c36c6b
5:51.84 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=6e9a94a466714b4d469cc06bff2ccc0698c36c6b&tochange=e70925dcdcd7352b71ee8f879a963ab097afb04c

As I suspected, bug 1976137. But that was only supposed to be code cleanup and shouldn't have caused a change in functionality, good or bad.

Comment 7

[James Teh [:Jamie]]

Aha. Bug 1977544 changed the cached caret rect to be relative to the document, but it continued to pass that rect unaltered to PlatformFocusEvent and PlatformCaretMoveEvent, which expect a rect in absolute screen coordinates. Bug 1976137 cleaned things up so that we use HyperTextAccessibleBase::GetCaretRect across the board and completely removed the caret rect argument to those Platform*Event methods.

We already know that bug 1976137 works, so it's probably simplest to uplift that. We only need part 1; the rest are purely cleanup.

Comment 8

[James Teh [:Jamie]]

[Tracking Requested - why for this release]: Breaks text entry with Windows Magnifier.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1977544

Comment 10

[Dianna Smith [:diannaS]]

Marking 142 as fixed for 142.0.1 (Aug 27) since bug 1976137 part1 has been uplifted

Comment 11

[Hugo Simões]

Thanks! It appears to be working fine now. The text focus of Windows Magnifier is now following the cursor when I type in a webpage.