1984063 - [wpt-sync] Sync PR 54423 - Add `column-height` to `columns` shorthand. Reset `column-wrap`.

Status: RESOLVED FIXED

(Core :: Layout: Columns, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 54423 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/54423
Details from upstream follow.

Morten Stenshorne <[e-mail]> wrote:

Add column-height to columns shorthand. Reset column-wrap.

Add column-height to the columns shorthand, as resolved here:
https://github.com/w3c/csswg-drafts/issues/12050#issuecomment-3160860557

The new syntax is: [ \<'column-width'> || \<'column-count'> ] [ / \<'column-height'> ]?.

Additionally the columns shorthand now resets the column-wrap
property to its initial value.

The new serialization code for columns also strips extraneous auto
keywords, so that e.g. columns:auto gets serialized as columns:auto,
not columns:auto auto, so that round-tripping no longer fails in
CSSParserImplTest.AllPropertiesCanParseImportant. This fix also affects
other tests, so that their expectations had to be updated.

Furthermore, since new longhands are added to the columns shorthand,
specifying only column-count and column-width now will result in
an empty string from getPropertyValue("columns"), since two longhands
are missing. Tests had to be updated because of this as well.

All behind runtime flag MulticolColumnWrapping.

Generated with gemini-cli assistance #ai-assisted (except for tests -
they are handwritten)

Bug: 436847954, 403183884
Change-Id: Iaf56d1fd0320d5df50228c58fb6669647c8728e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6850512
Reviewed-by: Rune Lillesveen \<[e-mail]>
Commit-Queue: Morten Stenshorne \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1503842}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=14581d645c003318b28fea68715f78e1ecbdccb8

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Attachment: Notable wpt changes

# CI Results

Ran 14 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 650 tests

## Status Summary

### Firefox
`OK`  : 7[GitHub] 89[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt]
`PASS`: 142[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 329[GitHub] 1385[Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt] 1739[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] 1743[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt] 1745[Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt]
`FAIL`: 295[GitHub] 365[Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt] 424[Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt] 426[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt]

### Chrome
`OK`  : 7
`PASS`: 365
`FAIL`: 259

### Safari
`OK`  : 7
`PASS`: 329
`FAIL`: 295

## Links
[Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=14581d645c003318b28fea68715f78e1ecbdccb8)
[GitHub PR Head](https://wpt.fyi/results/?sha=abaf1053a13f3094134ebff0fecf5f6639afbeb5&label=pr_head)
[GitHub PR Base](https://wpt.fyi/results/?sha=abaf1053a13f3094134ebff0fecf5f6639afbeb5&label=pr_base)

## Details

(See attachment for full changes)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/127aa5a44e46
https://hg.mozilla.org/integration/autoland/rev/b9827bc8f4f8
[wpt PR 54423] - Add `column-height` to `columns` shorthand. Reset `column-wrap`., a=testonly
https://github.com/mozilla-firefox/firefox/commit/0b8c36ca36a8
https://hg.mozilla.org/integration/autoland/rev/ebca7e8b5831
[wpt PR 54423] - Update wpt metadata, a=testonly

Comment 4

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/b9827bc8f4f8
https://hg.mozilla.org/mozilla-central/rev/ebca7e8b5831