1984102 - Consider re-introducing some of the AutoTArray-specific optimizations in nsTArray

Status: RESOLVED FIXED

(Core :: XPCOM, task)

Description

[Emilio Cobos Álvarez [:emilio]]

As per Mayank's comment the regressing bug probably has introduced some speedometer regressions.

Here's a try run reintroducing some of these:

• https://perf.compare/compare-lando-results?baseLando=148686&newLando=148720&baseRepo=try&newRepo=try&framework=13

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1984102 - Keep AutoTArray bit across relocations. r=nika!

This re-introduces some of the special-cases that we had before
bug 1983704, in a somewhat simpler way (by cleaning up AutoBuffer, and
forcing it to be 8-byte aligned).

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1984102 - Remove nsTArray-inl.h. r=nika!

This file is very annoying to edit, as editors choke on it, and it's
only included from nsTArray.h. So get rid of it.

Comment 3

[Phabricator Automation]

Comment on attachment 9508167 [details]
Bug 1984102 - Remove nsTArray-inl.h. r=nika!

Revision D261751 was moved to bug 1984195. Setting attachment 9508167 [details] to obsolete.

Comment 4

[Emilio Cobos Álvarez [:emilio]]

https://perf.compare/compare-lando-results?baseLando=148733&newLando=148814&baseRepo=try&newRepo=try&framework=13

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1abbe15a025d
https://hg.mozilla.org/integration/autoland/rev/9df93d7a24be
Keep AutoTArray bit across relocations. r=nika

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7008f88d9130
https://hg.mozilla.org/integration/autoland/rev/59b56e35fd8b
Revert "Bug 1984102 - Keep AutoTArray bit across relocations. r=nika" for causing leaks @chrome.toml.

Comment 7

[agoloman]

Backed out for causing multiple failures.

• Backout link
  Crashtest failures
• Push with failures
• Failure Log
  ————————————————————————————————————
  xpc failures
• Push with failures
• Failure Log
  ————————————————————————————————————
  Gtest failures
• Push with failures
• Failure Log
  ————————————————————————————————————
  xpc failures @est_persist_eviction.js
• Push with failures
• Failure Log

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5ebe0d2d7ae5
https://hg.mozilla.org/integration/autoland/rev/cdf5899258d8
Keep AutoTArray bit across relocations. r=nika

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/25907d55223a
https://hg.mozilla.org/integration/autoland/rev/23304f4eb710
Revert "Bug 1984102 - Keep AutoTArray bit across relocations. r=nika" for causing multiple crashes.

Comment 10

[agoloman]

Backed out for causing multiple crashes.

• Backout link
• Push with failures
• Failure Log

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/005c70c1c53f
https://hg.mozilla.org/integration/autoland/rev/a8efdd88e775
Keep AutoTArray bit across relocations. r=nika

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b7f48fe3f361
https://hg.mozilla.org/integration/autoland/rev/3dbe5b5f301e
Work around the hazard analysis.
https://github.com/mozilla-firefox/firefox/commit/b99949c20fe9
https://hg.mozilla.org/integration/autoland/rev/d849fe0372a3
Work around a bindgen issue on i686-android.

Comment 13

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/a8efdd88e775
https://hg.mozilla.org/mozilla-central/rev/3dbe5b5f301e
https://hg.mozilla.org/mozilla-central/rev/d849fe0372a3