1984105 - Disable LNA checks for Captive Portals

Status: NEW

(Core :: DOM: Networking, enhancement, P2)

Description

[Sunil Mayya]

In order to reduce prompt fatigue for our users, we would like to disable LNA when using captive portals -> https://bugzilla.mozilla.org/show_bug.cgi?id=1980302#c23

Comment 1

[Sunil Mayya]

[Tracking Requested - why for this release]:

Comment 3

[Donal Meehan [:dmeehan]]

Sunil, next week is the final week of Fx144 Nightly before Fx144 goes to Beta.
This is tracked for Fx144 as requested, but will a patch land before we go to Beta?

Comment 4

[Sunil Mayya]

Hey Donal, we dont want to land this fix for 144 as LNA is planned currently for 145

Comment 5

[Sunil Mayya]

[Tracking Requested - why for this release]:

Comment 6

[Pascal Chevrel:pascalc]

(In reply to Sunil Mayya from comment #4)

Hey Donal, we dont want to land this fix for 144 as LNA is planned currently for 145

Is LNA still planned for shipping with 145? Is that pref-controlled? Thanks

Comment 7

[Sunil Mayya]

(In reply to Pascal Chevrel:pascalc from comment #6)

(In reply to Sunil Mayya from comment #4)

Hey Donal, we dont want to land this fix for 144 as LNA is planned currently for 145

Is LNA still planned for shipping with 145? Is that pref-controlled? Thanks

LNA is still planned for 145, however with a rollout experiment. Additionally, we are planning it to be released only to a limited set of our users (ETP strict). More details will follow soon once we make the decision.

Comment 8

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1984105 - Disable Public to Private network LNA checks for Captive Portals r=sunil

This patch adds a isCaptivePortalTab field to the browsingContext.
We still keep setting the LOAD_FLAGS_DISABLE_TRR loadFlags,
though we could probably move that to BrowsingContext eventually.

nsHttpChannel now automatically allows captive portal browsing contexts
to do public -> private loads without prompting.

Comment 9

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1984105 - Make sure AllowedToConnectToIpAddressSpace checks pending permissions correctly r=sunil

This check was looking at whether both permissions were pending.
This means that if either one was granted, we would never show
the prompt for the other kind.