1984157 - Handle Vary headers for Compression Dictionaries

Status: RESOLVED FIXED

(Core :: Networking: Cache, task, P2)

Description

[Randell Jesup [:jesup] (needinfo me)]

We need to ensure that we ignore vary=Available-Dictionary and Accept-Encoding if we decompressed before storing in the cache (and thus changed the content-type). This avoids reloading or verifying if we access it from the cache. (This is tested for in the WPTs and mentioned in the spec)

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1984157: Vary support for Compression Dictionaries r=#necko-reviewers!

Also fixes a bit of telemetry

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/fa667bc385fa
https://hg.mozilla.org/integration/autoland/rev/a8943988bc73
Vary support for Compression Dictionaries r=necko-reviewers,valentin

Comment 3

[Sandor Molnar[:smolnar]]

Backed out for causing multiple bustages/failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/837a3d407e1c473641116eb9e1a150237c764645

Push with failures

Failure log -> TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/netwerk/test/unit/test_dictionary_storage.js:595:9 | 'headerValue' is assigned a value but never used. (no-unused-vars)

Failure log -> ERROR - /builds/worker/checkouts/gecko/netwerk/streamconv/converters/nsHTTPCompressConv.cpp:358:23: error: format '%d' expects argument of type 'int', but argument 4 has type 'nsresult' [-Werror=format=]

Failure log -> ERROR - /builds/worker/workspace/obj-build/dist/include/mozilla/net/Dictionary.h:313:14: error: unused variable 'rv' [-Werror,-Wunused-variable]

Failure log -> TEST-UNEXPECTED-FAIL | netwerk/test/unit/test_trr.js | test_server_up - [test_server_up : 84] "undefined" == "Error: could not find id"

Failure log -> TEST-UNEXPECTED-FAIL | /service-workers/service-worker/worker-interception.https.html

Failure log -> TEST-UNEXPECTED-FAIL | devtools/client/netmonitor/test/browser_net_copy_headers.js | Timed out while polling clipboard for requested data

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/a8943988bc73

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/683c7f75bb5c
https://hg.mozilla.org/integration/autoland/rev/8d4fd5248e1f
Vary support for Compression Dictionaries r=necko-reviewers,valentin

Comment 6

[amarc]

Backed out for causing multiple failures

• Backout link
• Push with failures
• Failure Log
• Failure Log 2
• Failure Log 3

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1288fcf5b71b
https://hg.mozilla.org/integration/autoland/rev/40d7d53a96c8
Vary support for Compression Dictionaries r=necko-reviewers,valentin

Comment 8

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/40d7d53a96c8

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/fa25812c95a6
https://hg.mozilla.org/integration/autoland/rev/1ed0e9bb65a4
Vary support for Compression Dictionaries r=necko-reviewers,valentin

Comment 10

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/1ed0e9bb65a4

Comment 11

[Atila Butkovits]

Backed out for causing failures /dictionary-compressed.tentative.https.html.

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/339cb96b8aea9a433abdfee35eca4472ecb7074e

Push where failures started: https://treeherder.mozilla.org/jobs?repo=autoland&searchStr=windows%2C11%2Cx86%2C24h2%2Copt%2Cweb%2Cplatform%2Ctests%2Ctest-windows11-32-24h2%2Fopt-web-platform-tests%2Cwpt12&revision=f63dea815067f6fefbac80cce46e1a0589f66a31&selectedTaskRun=OXPZFu52Tyq66R0qicmggw.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=529651894&repo=autoland&task=OXPZFu52Tyq66R0qicmggw.0&lineNumber=10724

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/780bddc9453d
https://hg.mozilla.org/integration/autoland/rev/94a206315599
Vary support for Compression Dictionaries r=necko-reviewers,valentin

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/62f94885b247
https://hg.mozilla.org/integration/autoland/rev/38933633043c
Vary support for Compression Dictionaries r=necko-reviewers,valentin

Comment 14

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/38933633043c