1984171 - Use spidermonkey regex in URLPattern

Status: RESOLVED FIXED

(Core :: Networking, defect, P2)

Description

[edgul]

There is at least one WPT failure that should be addressed by supplying the SpiderMonkey regex to the URLPattern crate:
Pattern: [{"pathname":"*{}**?"}] Inputs: [{"pathname":"foobar"}]

Let's fix this as a followup to the URLPattern interop 2025 project.

Comment 1

[edgul]

Attachment: WIP: Bug 1984171 - feed spidermonkey regex into urlpattern crate for matching

Comment 2

[edgul]

Quick status update for anyone following:

The above patch contains an almost working prototype where we provide a rust implementation of Spidermonkey Regex functionality to the urlpattern crate. We create C-API for the necessary SM calls and invoke from rust. Note that the current approach is one that creates the SM RegExp object on demand rather than handling any GC problems created by passing SM GC-controlled objects through rust. This has obvious performance issues that hopefully we can resolve after we get the POC working.

Note that the above patch depends on upstreaming a small amount of changes to the urlpattern crate. So far the necessary changes are shown here: https://github.com/denoland/rust-urlpattern/compare/main...edgul:rust-urlpattern:tmp

Comment 3

[Valentin Gosu [:valentin]]

Attachment: WIP: Bug 1984171 - temp local vendor of urlpattern + ed's changes

Comment 4

[edgul]

The interop aspect of this project is closing, moving this into queue to be handled as maintenance

Comment 6

[edgul]

Attachment: WIP: Bug 1984171 - Adding spidermonkey regex without using urlpattern crate

Comment 7

[edgul]

Attachment: WIP: Bug 1984171 - fixed the crashes and re-added the tests

Comment 8

[edgul]

Attachment: WIP: Bug Bug 1984171 - fixed a few tests

Comment 9

[edgul]

Attachment: WIP: Bug 1984171 - quick and dirty get compiling with spidermonkey regex pass around

Comment 10

[edgul]

Attachment: WIP: Bug 1984171 - Fixed spidermonkey_matches to return None on failure

Comment 11

[edgul]

Attachment: WIP: Bug 1984171 - Fixed encoding test failues

Comment 12

[edgul]

Attachment: Bug 1984171 - Added spidermonkey regex into URLPattern by integrating with urlpattern crate r?#necko-reviewers

Comment 13

[edgul]

Attachment: Bug 1984171 - Vendor in urlpattern 0.5.0 crate r?#necko-reviewers

Comment 14

[edgul]

Attachment: Bug 1984171 - Add URLPattern GC incremental slicing for spidermonkey regexp obj r?iain,smaug

This patch adds Trace functions so that when incremental GC happens we can Trace down to the spidermonkey regexp obj that is stored in the urlpattern::component. It's seems a bit complicated because of having to pass through the ffi boundary.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/35fa66706d19
https://hg.mozilla.org/integration/autoland/rev/dc5e3332bf3d
Vendor in urlpattern 0.5.0 crate r=necko-reviewers,supply-chain-reviewers,valentin
https://github.com/mozilla-firefox/firefox/commit/ed54d1409d54
https://hg.mozilla.org/integration/autoland/rev/937cfcb68de4
Added spidermonkey regex into URLPattern by integrating with urlpattern crate r=necko-reviewers,valentin,iain,smaug

Comment 16

[Phabricator Automation]

Comment on attachment 9538010 [details]
Bug 1984171 - Add URLPattern GC incremental slicing for spidermonkey regexp obj r?iain,smaug

Revision D279222 was moved to bug 2011529. Setting attachment 9538010 [details] to obsolete.

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d5adac594cec
https://hg.mozilla.org/integration/autoland/rev/24c00baf33d0
Revert "Bug 1984171 - Added spidermonkey regex into URLPattern by integrating with urlpattern crate r=necko-reviewers,valentin,iain,smaug" for causing build bustages

Comment 18

[Cristina Horotan [:chorotan]]

Backed out for causing build bustages

Backout link

Push with failures

Failure log

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3fe7170728cb
https://hg.mozilla.org/integration/autoland/rev/52ecd38c69f1
Added spidermonkey regex into URLPattern by integrating with urlpattern crate r=necko-reviewers,valentin,iain,smaug

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a47d3d742256
https://hg.mozilla.org/integration/autoland/rev/d8594f11efad
Revert "Bug 1984171, Bug 2011767 - Added spidermonkey regex into URLPattern by integrating with urlpattern crate r=necko-reviewers,valentin,iain,smaug" for causing failures complaining about regexResult.

Comment 21

[Atila Butkovits]

Backed out for causing failures complaining about regexResult.

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/d8594f11efadec8cbad9c477e149b65e4444d330

Push where failures started: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=P7sPJKPyThSZ5Pa3n272Tg.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=9a8624999ab9dfd0e34d53f4fd6dfe90bfadc9c6

Failure log: https://treeherder.mozilla.org/logviewer?job_id=544954988&repo=autoland&task=P7sPJKPyThSZ5Pa3n272Tg.0&lineNumber=4836

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/bb8fd8d7fbbc
https://hg.mozilla.org/integration/autoland/rev/d676f790d29c
Added spidermonkey regex into URLPattern by integrating with urlpattern crate r=necko-reviewers,valentin,iain,smaug

Comment 23

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/d676f790d29c