1984215 - [wpt-sync] Sync PR 54433 - Allow style-dirty size query subtrees in parent document

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 54433 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/54433
Details from upstream follow.

Rune Lillesveen <[e-mail]> wrote:

Allow style-dirty size query subtrees in parent document

AssertLayoutTreeUpdated() is called both before and after layout. When
called before layout, we allow size container subtrees be style dirty
because we may defer style recalc to an interleaved pass during layout
for them.

When updating style and layout tree for frames, we asserted that the
parent frame was style-clean, even for size container subtrees. That is
not necessarily true, especially for SVG frames where we update style
and layout tree for them before the layout pass for the parent frame.

Allow size container subtrees to be style-dirty for all other cases than
Document::AssertLayoutTreeUpdatedAfterLayout().

Bug: 439886903
Change-Id: I8959506f3cddb7169b1df60ecadae9209842f86e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6867910
Reviewed-by: Stefan Zager \<[e-mail]>
Commit-Queue: Rune Lillesveen \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1504267}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=a6a1bed1752eca4164dcf3da113fe351c7b50a72

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 14 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 57 tests

Status Summary

Firefox

PASS: 1[GitHub] 57[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt]

Chrome

PASS: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/82e0a31be950
https://hg.mozilla.org/integration/autoland/rev/f1c9ba88d91f
[wpt PR 54433] - Allow style-dirty size query subtrees in parent document, a=testonly

Comment 4

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/f1c9ba88d91f