1984274 - Statistics panel scroll hides part of the UI

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P3)

Description

[Julian Descottes [:jdescottes]]

Attachment: image.png

See the screenshot, if the toolbox is not tall enough the Statistics panel will not be able to display the top of its content. Here we are missing the headers of the table.

Pretty easy to trigger, not a regression.

Comment 1

[Andre Coullard]

I'm interested in working on this.
Could it be assigned to me?

Comment 2

[Julian Descottes [:jdescottes]]

Sure Andre, assigning the bug to you. You can check our documentation to setup the environment: https://firefox-source-docs.mozilla.org/setup/index.html

To reproduce this bug, you can use the following steps:

• open a tab on youtube (it happens to load 6 "categories" of network resources, so it's nice to trigger the issue)
• open devtools > network
• disable cache
• click on the statistics panel icon (bottom left of the network panel)

You might want to resize the window to have a width close to 1200px. That makes most of the cells in the size column wrap on 2 lines, which increases the height needed to display all the information - on a sidenote, maybe we should update the layout to avoid this. And resize the toolbox itself so that the height is small as well (around 300px).

Comment 3

[Andre Coullard]

Attachment: screen shot of fix attempt 1

OK, I've got something working. Is this what you envisioned?
I've made the header "sticky" so it is always visible as the panel is resized.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit BugBot documentation.

Comment 5

[Franccesco]

Hello, I'm new, this seems like a good first bug for me. Could this bug be assigned to me?

Comment 6

[Franccesco]

(In reply to Franccesco from comment #5)

Hello, I'm new, this seems like a good first bug for me. Could this bug be assigned to me?

I have recreated the bug locally and I am working on a fix.

Comment 7

[Franccesco]

Attachment: Bug 1984274 - Fix to make sure the pie table chart is fully visible with scroll on

Comment 8

[Franccesco]

I reproduced the issue locally and submitted a fix for review.

Phabricator revision:
https://phabricator.services.mozilla.com/D279103

Tests run:

./mach test devtools/client/netmonitor

Notes:
browser_net_simple-request-data.js fails locally with a headers count mismatch (“Got 11, expected 10”) and timeout even when my patch is stashed, so this appears unrelated to my changes.

My patch only touches: StatisticsPanel.css.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/fe54604bc6bc
https://hg.mozilla.org/integration/autoland/rev/82ac923f6cc4
Fix to make sure the pie table chart is fully visible with scroll on r=bomsy

Comment 10

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/82ac923f6cc4