1984353 - "Unpin from Overflow Menu" does not remove the menu header

Status: VERIFIED FIXED

(Firefox :: IP Protection, defect, P2)

Description

[Valentina Virlics [:vvalentina], Ecosystem QA]

Attachment: image.png

[Affected versions]:

• Firefox Beta 143.0b2;
• Firefox Nightly 144.0a1 (20/08/2025);

[Affected Platforms]:

• Windows 11 x64

[Prerequisites]:

• Have the "browser.ipProtection.enabled" pref set to true in the "about:config" page.
• You are connected to Firefox Sync.

[Steps to reproduce]:

1. Open the browser using the profile from the prerequisites.
2. Click the "Firefox VPN" toolbar button and turn ON the VPN.
3. Right-click on the VPN toolbar icon and select "Pin to Overflow menu".
4. Go to Overflow menu and right-click on the VPN while selecting "Unpin from Overflow Menu".
5. Go to toolbar and click VPN icon.
6. Observe the panel header.

[Expected result]:

• The panel has one Firefox VPN header;

[Actual result]:

• The panel has two Firefox VPN headers;

[Notes]:

• Attached a screenshot of the issue.

Comment 1

[Fred Chasen [:fchasen]]

Attachment: Bug 1984353 - Hide extra header when IPProtection widget is in a menu. r=#ip-protection-reviewers!

Updates the IPProtection widget to hide the header created by PanelMultiView.headerText when in the overflow menu.

This is just a quick fix, same as the profile panel has, and will need a follow up to update headerText to not create headers for panels that already have custom ones.

Comment 3

[Santiago]

Moving to "At-scale post-launch improvements".
(a) This is a nit on a specific workflow (b) It's aesthetic but doesn't impact functionality.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/4db9d5a16e5c
https://hg.mozilla.org/integration/autoland/rev/40019c6d9cde
Hide extra header when IPProtection widget is in a menu. r=ip-protection-reviewers,desktop-theme-reviewers,kpatenio,Itiel

Comment 5

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/40019c6d9cde

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:fchasen, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox143 to wontfix.

For more information, please visit BugBot documentation.

Comment 7

[Fred Chasen [:fchasen]]

Attachment: Bug 1984353 - Hide extra header when IPProtection widget is in a menu.

Updates the IPProtection widget to hide the header created by PanelMultiView.headerText when in the overflow menu.

This is just a quick fix, and will need a follow up to update headerText to not create headers for panels that already have custom ones (and tests) in https://bugzilla.mozilla.org/show_bug.cgi?id=1985116.

Original Revision: https://phabricator.services.mozilla.com/D262030

Comment 8

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: Users who pin the VPN widget to the overflow menu will see double headers
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: None
• Risk associated with taking this patch: Low
• Explanation of risk level: Styling patch the hide elements to limit risk in this patch
• String changes made/needed: None
• Is Android affected?: no

Comment 9

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/0d1b93979881
https://hg.mozilla.org/releases/mozilla-beta/rev/7c4b87dbaf5d

Comment 10

[Valentina Virlics [:vvalentina], Ecosystem QA]

I have verified that this issue is no longer reproducible using the Firefox Release 143.0 and Firefox Beta 144.0b2 (25/09/17), installed on Windows 10 x64.
While pin/unpin to/from Overflow menu, there is no extra header for Firefox VPN.