1984370 - Focus doesn't show the subdomain in Custom Tabs

Status: RESOLVED FIXED

(Focus :: General, defect)

Description

[Michel Le Bihan]

This is the same bug 1979534 as in Fenix.

Steps to reproduce

1. Open an app that displays links using custom tabs. This could be an email client, a messaging app, or a social media app. I tested it with the Mastodon app and a custom-built app.
2. Send a link to a Google Sites page, such as https://sites.google.com/view/myevilwebsite. The link can be embedded indirectly (e.g., behind several redirects or within an HTML message), so the final destination may not be obvious before clicking.
3. Tap the link and confirm it opens in a Firefox Custom Tab.

Expected behavior

It should be possible to tell the difference between a Google Sites website and an official Google website. While it's unfortunate that Google allows custom user content under a subdomain of google.com, that's a case that should be handled by Firefox. I propose to show the whole domain, but with the subdomain in a different (secondary) color in Custom Tabs.

Actual behavior

In the Custom Tab only the google.com registrable domain (eTLD+1) is displayed in the urlbar. This makes it easy to confuse a Google Sites website with malicious content for an official Google page.

Comment 1

[Michel Le Bihan]

Attachment: (secure)

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d239bda81bbb
https://hg.mozilla.org/integration/autoland/rev/3be721958830
Set toolbar URL colors and show subdomain in Focus custom tabs. r=petru,mcarare,android-reviewers

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/3be721958830

Comment 4

[Daniel Veditz [:dveditz]]

Depends on ColoredDomain implemented in the Fenix version of this, bug 1979534