1984448 - [wpt-sync] Sync PR 54449 - Don't crash if cancelling the previous navigation starts a new one in DispatchNavigateEvent

Status: RESOLVED FIXED

(Core :: DOM: Navigation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 54449 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/54449
Details from upstream follow.

Nate Chapin <[e-mail]> wrote:

Don't crash if cancelling the previous navigation starts a new one in DispatchNavigateEvent

This updates the logic for aborting an existing navigation when
preparing to fire a new navigate even to match the spec update in
https://github.com/whatwg/html/pull/11409.

It also updates cleanup of the ongoing api method tracker to
occur before firing navigatesuccess/navigateerror, so that we do
not clobber a new api method tracker if a new navigation is started
inside one of those events.

Fixed: 419746417, 431135033, 428022635
Change-Id: Ieccbc56085b5763564f19e0b9f11903aeb6ae82c
Reviewed-on: https://chromium-review.googlesource.com/6622087
WPT-Export-Revision: abd94eafd290d403acda12ec76b03dc417652f12

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=88b663a1a3f2a2c05e20bc9898504d3db0f3a022

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Attachment: Notable wpt changes

# CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 108 tests and 1 subtests

## Status Summary

### Firefox
`OK`     : 1[GitHub] 97[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt]
`PASS`   : 73[Gecko-android-em-7.0-x86_64-qr-debug-geckoview] 74[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt]
`CRASH`  : 1
`FAIL`   : 1[GitHub] 32[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt]
`TIMEOUT`: 4[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] 7[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt]
`ERROR`  : 1

### Chrome
`CRASH`  : 1

### Safari
`OK`     : 1
`FAIL`   : 1

## Links
[Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=88b663a1a3f2a2c05e20bc9898504d3db0f3a022)
[GitHub PR Head](https://wpt.fyi/results/?sha=7604d1259baeb307908fc642222c57a6a896f76a&label=pr_head)
[GitHub PR Base](https://wpt.fyi/results/?sha=7604d1259baeb307908fc642222c57a6a896f76a&label=pr_base)

## Details

### Crashes
* [/navigation-api/navigate-event/navigate-multiple-navigation-navigate.html](https://wpt.live/navigation-api/navigate-event/navigate-multiple-navigation-navigate.html) [[wpt.fyi](https://wpt.fyi/results/navigation-api/navigate-event/navigate-multiple-navigation-navigate.html)]: `CRASH` [`Gecko-linux2404-64-debug`, `Gecko-linux2404-64-opt`, `Gecko-windows11-32-24h2-debug`, `Gecko-windows11-32-24h2-opt`, `Gecko-windows11-64-24h2-debug`, `Gecko-windows11-64-24h2-opt`], `OK` [`GitHub`], `SKIP` [`Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview`, `Gecko-android-em-7.0-x86_64-qr-debug-geckoview`, `Gecko-android-em-7.0-x86_64-qr-opt-geckoview`]

(See attachment for full changes)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/73a30f12a91d
https://hg.mozilla.org/integration/autoland/rev/db7866d2ece6
[wpt PR 54449] - Don't crash if cancelling the previous navigation starts a new one in DispatchNavigateEvent, a=testonly
https://github.com/mozilla-firefox/firefox/commit/c91d73749d87
https://hg.mozilla.org/integration/autoland/rev/cbccbc4da80e
[wpt PR 54449] - Update wpt metadata, a=testonly

Comment 4

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/db7866d2ece6
https://hg.mozilla.org/mozilla-central/rev/cbccbc4da80e