1984604 - Margin around expanded shorthand properties is too big

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, defect)

Description

[Julian Descottes [:jdescottes]]

Attachment: image.png

Small UI nit.

• open data:text/html,<div style="margin:5px">inspect me
• inspect div
• expand the margin property

There are really big margins around the expanded properties, which makes the layout look a bit broken.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1984604 - [devtools] Remove margin around ruleview computedlist, r=nchevobbe

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

After Bug 1838803, we're not using a <ul> for the rule declarations list, which means the computed list isn't matching the following UA stylesheet rule:

:is(ul, ol, dir, menu, dl) ul {
  margin-block-start: 0;
  margin-block-end: 0;
}

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1838803

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/33ce8f0f9799
https://hg.mozilla.org/integration/autoland/rev/0474fbec92f2
[devtools] Remove margin around ruleview computedlist, r=nchevobbe,devtools-reviewers

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/0474fbec92f2

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:jdescottes, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox143 to wontfix.

For more information, please visit BugBot documentation.

Comment 7

[Julian Descottes [:jdescottes]]

Old regression, minor UI nit, no need to uplift.