1984620 - [wpt-sync] Sync PR 54456 - ContainerTiming: add containerTimingNesting attribute support

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 54456 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/54456
Details from upstream follow.

Jose Dapena Paz <[e-mail]> wrote:

ContainerTiming: add containerTimingNesting attribute support

In a hierarchy of several container timing roots (elements with the
containertiming flag), paint information is not propagated to the
parent roots.

With this change, we introduce a nesting policy, that can be
specified with the attribute "containertiming-nesting". This can be
added to nodes with "containertiming" attribute.

The default mode is non propagating (painting of a container timing
tree is not forwarded to other container tree roots the node may be
included in).

But we support two additional modes that are passed as parameters of
"containertiming-nesting":

• "transparent": the paints are forwarded to next container tree root
  as they are.
• "shadowed": the paints are forwarded, but replacing the specific
  element with the container tree root.

Additional WPT tests provided for nesting, and for its interaction with
containertiming-ignore.

Explainer: https://github.com/bloomberg/container-timing/blob/main/README.md
Chromestatus: https://chromestatus.com/feature/5110962817073152
I2P: https://groups.google.com/a/chromium.org/g/blink-dev/c/J-WxY0w7bNk/m/VkqnomK-CAAJ

Ticket for nesting policy specification discussion:
https://github.com/bloomberg/container-timing/issues/3

Bug: 382422286
Change-Id: I0c932823a9e72ca87558bbf85ad893c5e3696d25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6270778
Reviewed-by: Joey Arhar \<[e-mail]>
Commit-Queue: José Dapena Paz \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1504890}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=757d5956291f48b8150efa93b64626cf722a7ba8

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 10 tests and 1 subtests

Status Summary

Firefox

OK : 10
FAIL: 10

Chrome

OK : 10
PASS: 5
FAIL: 5

Safari

OK : 10
FAIL: 10

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /container-timing/tentative/nested-containertiming-child-img-with-ignore.html [wpt.fyi]
  • A parent containertiming root with transparent nesting policy does not get paints from children containertiming roots if an intermediate ignore is set.: FAIL (Chrome: PASS, Safari: FAIL)
• /container-timing/tentative/nested-containertiming-child-img-with-intermediate-nesting-transparent.html [wpt.fyi]
  • A parent containertiming root with default nesting policy does not get paints from children containertiming roots, even if an intermediate node could set a different nesting policy.: FAIL (Chrome: PASS, Safari: FAIL)
• /container-timing/tentative/nested-containertiming-child-img.html [wpt.fyi]
  • A parent containertiming root with default nesting policy does not get paints from children containertiming roots.: FAIL (Chrome: PASS, Safari: FAIL)
• /container-timing/tentative/nested-containertiming-nesting-change-from-invalid.html [wpt.fyi]
  • A parent containertiming root switches from invalid nesting policy to transparent, generating one painting from each container timing root.: FAIL (Chrome: FAIL, Safari: FAIL)
• /container-timing/tentative/nested-containertiming-nesting-change-to-invalid.html [wpt.fyi]
  • A parent containertiming root switches from transparent nesting policy to invalid, generating only a paint for the inner container timing.: FAIL (Chrome: PASS, Safari: FAIL)
• /container-timing/tentative/nested-shadowed-containertiming-child-img.html [wpt.fyi]
  • A parent containertiming root with shadowed nesting policy gets only child containertiming paints without element data.: FAIL (Chrome: FAIL, Safari: FAIL)
• /container-timing/tentative/nested-shadowed-to-transparent-containertiming-child-img.html [wpt.fyi]
  • A parent containertiming root with shadowed then transparent nesting policy gets child containertiming paints with element data.: FAIL (Chrome: FAIL, Safari: FAIL)
• /container-timing/tentative/nested-transparent-containertiming-child-img-with-intermediate-ignore.html [wpt.fyi]
  • A parent containertiming root with transparent nesting policy and child containertiming including image, an intermediate ignore blocks paints to parent root.: FAIL (Chrome: PASS, Safari: FAIL)
• /container-timing/tentative/nested-transparent-containertiming-child-img.html [wpt.fyi]
  • A parent containertiming root with transparent nesting policy gets child containertiming paints with element data.: FAIL (Chrome: FAIL, Safari: FAIL)
• /container-timing/tentative/nested-transparent-to-shadowed-containertiming-child-img.html [wpt.fyi]
  • A parent containertiming root with transparent then shadowed nesting policy gets child containertiming paints without element data.: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0c7b295a4ddb
https://hg.mozilla.org/integration/autoland/rev/930b89cf6ec5
[wpt PR 54456] - ContainerTiming: add containerTimingNesting attribute support, a=testonly
https://github.com/mozilla-firefox/firefox/commit/61c3fef21edf
https://hg.mozilla.org/integration/autoland/rev/4dcf4eb93ace
[wpt PR 54456] - Update wpt metadata, a=testonly

Comment 4

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/930b89cf6ec5
https://hg.mozilla.org/mozilla-central/rev/4dcf4eb93ace