1984747 - Enable Link Previews by default

Status: RESOLVED FIXED

(Core :: Machine Learning: General, enhancement)

Description

[Tim Xia]

Enable Link Previews by default

Comment 1

[Tim Xia]

Attachment: Bug 1984747: Enable Link Previews by default - r=Mardak

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c4ae6453e230
https://hg.mozilla.org/integration/autoland/rev/95446fc755fd
Enable Link Previews by default - r=Mardak,firefox-ai-ml-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d375bf89a148
https://hg.mozilla.org/integration/autoland/rev/069d1b13b705
Revert "Bug 1984747: Enable Link Previews by default - r=Mardak,firefox-ai-ml-reviewers" for causing mochitest failures @ browser_contextmenu_sendpage.js @ browser_contextmenu.js

Comment 4

[pstanciu]

Backed out for causing mochitest failures @ browser_contextmenu_sendpage.js @ browser_contextmenu.js

• https://hg.mozilla.org/integration/autoland/rev/069d1b13b7050fa0b0d89afc736823c2f2d71a5b
• Push with failures
• Failure Log

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/de22534abec8
https://hg.mozilla.org/integration/autoland/rev/6b4b141694c0
Enable Link Previews by default - r=Mardak,firefox-ai-ml-reviewers

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a4351b9ca598
https://hg.mozilla.org/integration/autoland/rev/5a96c99c22ca
Revert "Bug 1984747: Enable Link Previews by default - r=Mardak,firefox-ai-ml-reviewers" for causing bc failure on browser_contextmenu.js

Comment 7

[Narcis Beleuzu [:NarcisB]]

Backed out for causing bc failure on browser_contextmenu.js

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/5a96c99c22ca06941dba6d4690139b637d17afce
Log link: https://treeherder.mozilla.org/logviewer?job_id=532812409&repo=autoland&task=JmI6hQAVS6SLsaJsan13MQ.0&lineNumber=2059

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/490ea2332c37
https://hg.mozilla.org/integration/autoland/rev/04cf8746f9e8
Enable Link Previews by default - r=Mardak,firefox-ai-ml-reviewers,fluent-reviewers,bolsson

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/04cf8746f9e8

Comment 10

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: Without this, users won’t have Link Preview enabled by default. This delays broader release of Link Preview feature to all uesrs in English locale. The patch also removes onboarding and makes Link Preview preferences always visible
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: Validate it working by default

1. Start Beta with a fresh profile.

2. Open about:config and verify:
   • browser.ml.linkPreview.enabled true (default-on)
   • browser.ml.linkPreview.supportedLocales "en"
   • browser.ml.linkPreview.noKeyPointsRegions "" (no region blocks)

3. Open a new tab, long-press any link, it shoud show Link Preview card

4. Open about:preferences and search “Link Preview”: settings should be visible even if you toggle the Enable Link Preview option off

5. Right-click a link: confirm a "Preview link" context-menu entry is present and preview behavior is stable with the menu.

Validate Key Points locale-based gating by tweaking locales:
• Set browser.ml.linkPreview.supportedLocales to "fr" (simulate EN not supported).
• Reload and preview an English article link: preview shows, but no Key Points section should be displayed.
• Restore to "en" and repeat: Key Points generate for English articles. (Matches new canShowKeyPoints logic.)

• Risk associated with taking this patch: low
• Explanation of risk level: The Link Preview has been tested in the lab experiments with no known stability issues. Current long-press based UX also does not interfere with regular browser browsing interaction. Various points of UX such as context menu are addressed by automated testing suite.
• String changes made/needed: No. No new string id is created, even though I want to note that there is an Access Key value change for context menu item that is approved by the fluent team.
• Is Android affected?: no

Comment 11

[Tim Xia]

Attachment: Bug 1984747: Enable Link Previews by default - r=Mardak

• Add locale-based gating logic
• Link Previews with Key Points to all English‑speaking users (EN locale, all geos)
• Link Previews without Key Points to all other users (all other locale, all geos)
• use canShowKeyPoints() for locale and region condition check
• set canShowPreferences to true all the time
• update tests
• change test condition for canShowPreferences to always true
• set onboarding to false all the time.
• remove browser_link_preview_onboarding.js
• fix linter
• remove ref to browser_link_preview_onboarding.js and tests in telemetry test
• remove test_nimbus_link_preview test 'cause we are enabling Link Preview by default
• fix browser_contextmenu_sendpage.js test
• fix broewser_contextmenu test and access key conflict

Original Revision: https://phabricator.services.mozilla.com/D262205

Comment 12

[Pascal Chevrel (relman team) -> :pascalc]

Tim, we are in our last week of beta and AFAIK, this was not a planned feature for 145. could the PM in charge of this feature reach out to me about it?
Thanks

Comment 13

[laustin]

(In reply to Pascal Chevrel:pascalc from comment #12)

Tim, we are in our last week of beta and AFAIK, this was not a planned feature for 145. could the PM in charge of this feature reach out to me about it?
Thanks

Hey Pascal - this is a feature we've had live in production (100% in US, CA, AU, GB) since 142 and have had clearance to scale since September 4. We've been reporting on this as a target for expanded distribution for a few weeks, but apparently not in a manner to give you the info you need. How can I assist? I'll reach out directly to help clarify.

Comment 14

[Pascal Chevrel (relman team) -> :pascalc]

Comment on attachment 9522756 [details]
Bug 1984747: Enable Link Previews by default - r=Mardak

We are in the final stage of stabilization for Firefox 145 Beta as we prepare to build the Release Candidate. This patch landed in Nightly only a few hours ago and is relatively large in scope. It is not a simple pref flip but a refactoring that also changes the rollout logic — moving from a geo-based rollout via Nimbus to a locale-based rollout in-tree.

Given the size, complexity, and very limited bake time, this change is too risky for a late Beta uplift. If we wish to expand the current rollout to more English-speaking users in 145, that can be achieved safely via Nimbus configuration. The updated implementation can then ride the 146 train (shipping in December) and benefit from additional pre-release testing and stabilization.

Comment 15

[Ciprian Georgiu, Desktop QA]

I've verified this bug as fixed on latest Nightly 146.0a1 under Win 11, macOS 28 and Ubuntu 24 with the info provided in comment 10.