Closed Bug 1984799 Opened 4 months ago Closed 3 months ago

Update WebGPU CTS to new version 0fb20da2efe90a2c38228709038f97b565dfc85c from 2025-08-22 16:15:27

Categories

(Core :: Graphics: WebGPU, task, P1)

task

Tracking

()

RESOLVED FIXED
144 Branch
Tracking Status
firefox144 --- fixed

People

(Reporter: update-bot, Assigned: ErichDonGubler)

References

(Blocks 1 open bug)

Details

(Whiteboard: [3pl-filed][task_id: MrDJyyQ9RD6x6N38_xeB3w])

Attachments

(3 files)

This update covers 6 commits. Here are the overall diff statistics, and then the commit information.


dom/webgpu/tests/cts/checkout/src/webgpu/api/operation/storage_texture/read_only.spec.ts | 16 +-
dom/webgpu/tests/cts/checkout/src/webgpu/api/operation/vertex_state/correctness.spec.ts | 19 +-
dom/webgpu/tests/cts/checkout/src/webgpu/api/validation/capability_checks/features/texture_formats_tier1.spec.ts | 140 ++-
dom/webgpu/tests/cts/checkout/src/webgpu/api/validation/createBindGroup.spec.ts | 2 +-
dom/webgpu/tests/cts/checkout/src/webgpu/format_info.ts | 9 +
dom/webgpu/tests/cts/checkout/src/webgpu/gpu_test.ts | 17 +
dom/webgpu/tests/cts/checkout/src/webgpu/shader/execution/expression/call/builtin/textureStore.spec.ts | 377 +++++++--
dom/webgpu/tests/cts/checkout/tools/gen_version | 2 +-
dom/webgpu/tests/cts/moz.yaml | 4 +-
testing/web-platform/mozilla/tests/webgpu/common/internal/version.js | 2 +-
testing/web-platform/mozilla/tests/webgpu/webgpu/api/operation/storage_texture/read_only.spec.js | 16 +-
testing/web-platform/mozilla/tests/webgpu/webgpu/api/operation/vertex_state/correctness.spec.js | 19 +-
testing/web-platform/mozilla/tests/webgpu/webgpu/api/validation/capability_checks/features/texture_formats_tier1.spec.js | 142 ++-
testing/web-platform/mozilla/tests/webgpu/webgpu/api/validation/createBindGroup.spec.js | 2 +-
testing/web-platform/mozilla/tests/webgpu/webgpu/format_info.js | 9 +
testing/web-platform/mozilla/tests/webgpu/webgpu/gpu_test.js | 17 +
testing/web-platform/mozilla/tests/webgpu/webgpu/shader/execution/expression/call/builtin/textureStore.spec.js | 383 +++++++--
17 files changed, 910 insertions(+), 266 deletions(-)


0fb20da2efe90a2c38228709038f97b565dfc85c by mwyrzykowski <105083895+mwyrzykowski@users.noreply.github.com>

https://github.com/gpuweb/cts/+/0fb20da2efe90a2c38228709038f97b565dfc85c
Authored: 2025-08-22 09:15:27 -0700
Committed: 2025-08-22 09:15:27 -0700

The specification says: (#4445)

https://www.w3.org/TR/webgpu/#adapter-capability-guarantees

minUniformBufferOffsetAlignment and minStorageBufferOffsetAlignment must both be ≥ 32 bytes.

but the test expected 128 to be unaligned and hence invalid. 128 mod 32 = 0.

Co-authored-by: Mike Wyrzykowski <mwyrzykowski@Mac-Studio.local>

Files Modified:

  • src/webgpu/api/validation/createBindGroup.spec.ts

02f6385d66880b112321acfb479b6734e23ae340 by May Mei <shanxing.mei@intel.com>

https://github.com/gpuweb/cts/+/02f6385d66880b112321acfb479b6734e23ae340
Authored: 2025-08-22 16:26:33 +0800
Committed: 2025-08-22 16:26:33 +0800

Add test for GPUTextureFormats' resolve capability with tier1 (#4446)

Texture-formats-tier1 supports resolve capability on below formats:

r8snorm, rg8snorm, rgba8snorm, rg11b10ufloat.

This commit adds test for these formats to be consistent with the spec.

Files Modified:

  • src/webgpu/api/validation/capability_checks/features/texture_formats_tier1.spec.ts

82016725b9facb3bbf2c0d361e33fadc5f98b230 by mwyrzykowski <105083895+mwyrzykowski@users.noreply.github.com>

https://github.com/gpuweb/cts/+/82016725b9facb3bbf2c0d361e33fadc5f98b230
Authored: 2025-08-21 08:37:26 -0700
Committed: 2025-08-21 08:37:26 -0700

The validation rules for https://www.w3.org/TR/webgpu/#abstract-opdef-validating-gpuvertexbufferlayout state (#4444)

...
attrib.offset is a multiple of the minimum of 4 and byteSize(attrib.format).
...

however the test was allowing for non four byte alligned offsets and expecting a passing result.

This test passes on Chrome as Chrome reports

maxVertexBufferArrayStride 2048

but was failing in Safari due to Safari reporting

maxVertexBufferArrayStride 65532 (64k)

which can be observed visiting https://webgpufundamentals.org/webgpu/lessons/webgpu-limits-and-features.html

Correct this by aligning to the min of 4 or the vertex size.

Co-authored-by: Mike Wyrzykowski <mwyrzykowski@Mac-Studio.local>

Files Modified:

  • src/webgpu/api/operation/vertex_state/correctness.spec.ts

e6e9758afadbaeb603a6eaf0752ec4f9fbb81381 by May Mei <shanxing.mei@intel.com>

https://github.com/gpuweb/cts/+/e6e9758afadbaeb603a6eaf0752ec4f9fbb81381
Authored: 2025-08-20 16:44:06 +0800
Committed: 2025-08-20 16:44:06 +0800

Add tests for Tier1 write-only storage texture access (#4442)

Texture-formats-tier1 supports the write-only GPUStorageTextureAccess on below formats:

r16unorm, r16snorm, rg16unorm, r16snorm, rgba16unorm, rgba16snorm, r8unorm, r8snorm,
r8uint, r8sint, rg8unorm, rg8snorm, rg8uint, rg8sint, r16uint, r16sint, r16float, rg16uint, rg16sint,
rg16float, rgb10a2uint, rgb10a2unorm, rg11b10ufloat.

This commit added tests for these formats to be consistent with the spec.

Files Modified:

  • src/webgpu/shader/execution/expression/call/builtin/textureStore.spec.ts

0636dedc5142ebe012b189a0576a1cb8fd083dc3 by May Mei <shanxing.mei@intel.com>

https://github.com/gpuweb/cts/+/0636dedc5142ebe012b189a0576a1cb8fd083dc3
Authored: 2025-08-20 16:29:00 +0800
Committed: 2025-08-20 16:29:00 +0800

Correct expected data in read-only related tests (#4441)

Set the default alpha channel value to 1 in expected data for formats without an alpha channel,
and modify expected data for the rgb10a2uint format to fix test errors.

Files Modified:

  • src/webgpu/api/operation/storage_texture/read_only.spec.ts

5e80f865d7f3d7342ccadac79b7be7389388b357 by mwyrzykowski <105083895+mwyrzykowski@users.noreply.github.com>

https://github.com/gpuweb/cts/+/5e80f865d7f3d7342ccadac79b7be7389388b357
Authored: 2025-08-18 12:10:28 -0700
Committed: 2025-08-18 12:10:28 -0700

The specification for createTexture says https://www.w3.org/TR/webgpu/#dom-gpudevice-createtexture (#4439)

  1. Validate texture format required features of descriptor.format with this.[[device]].
    If format requires a feature and device.[[features]] does not contain the feature:

Throw a TypeError.

but the test was expectation a validation error instead of an exception which does not align
with the specification.

Correct this by expecting an exception.

Co-authored-by: Mike Wyrzykowski <mwyrzykowski@Mac-Studio.local>

Files Modified:

  • src/webgpu/api/validation/capability_checks/features/texture_formats_tier1.spec.ts
  • src/webgpu/format_info.ts
  • src/webgpu/gpu_test.ts

Type: enhancement → task
Priority: -- → P1
Assignee: nobody → update-bot
Status: NEW → ASSIGNED
Assignee: update-bot → egubler
Attachment #9508931 - Attachment description: Bug 1984799 - Update WebGPU CTS to 0fb20da2efe90a2c38228709038f97b565dfc85c → Bug 1984799 - test(webgpu): update CTS to 0fb20da2efe90a2c38228709038f97b565dfc85c r=#webgpu-reviewers

The try push is done, we found jobs with unclassified failures.

Needs Close Investigation:

  • test-linux2204-64-wayland/opt-web-platform-tests-webgpu-backlog-long-1 - 1 of 3 failed on the same (retriggered) task (failed: T3ZOEYPES4-3dRHfroDDJQ)
  • test-linux2204-64-wayland/opt-web-platform-tests-webgpu-backlog-9 - 3 of 3 failed on the same (retriggered) task (failed: Chrd7TBdS2O8LxUscMzUjA, E6hI_rjrQrqf9Gfa9lHR1Q, WfuqX9DaREKuSIUZdJQw4w)
  • test-linux2204-64-wayland/opt-web-platform-tests-webgpu-backlog-16 - 3 of 3 failed on the same (retriggered) task (failed: c-stBsBgRoKrF7GioSM0NA, MW9HsDFhRSaduwJlnoDZRQ, S-Hc5oBTTQiT27m7YLPG-Q)
  • test-linux2204-64-wayland/opt-web-platform-tests-webgpu-backlog-5 - 1 of 3 failed on the same (retriggered) task (failed: dj2pyTUTQ8GCxfOtUFMzJA)
  • test-linux2204-64-wayland/opt-web-platform-tests-webgpu-backlog-long-4 - 1 of 3 failed on the same (retriggered) task (failed: EOfA-8CJTUmTgejofB6mPA)
  • test-windows11-64-24h2/opt-web-platform-tests-webgpu-backlog-long-2 - 1 of 3 failed on the same (retriggered) task (failed: BpVseQ-TQ1S2QwbTeDk05w)
  • test-windows11-64-24h2/opt-web-platform-tests-webgpu-backlog-long-4 - 2 of 3 failed on the same (retriggered) task (failed: d_eNsQU3RtyIm4px0GDAAA, fl2inhDkS_mZ34WWXYjvJA)
  • test-windows11-64-24h2/opt-web-platform-tests-webgpu-backlog-10 - 3 of 3 failed on the same (retriggered) task (failed: dqcAhOInTveR746Cg-W36Q, eb-Bq9qlTxOEOl299cEMXw, HwDahFiHRDGz2D2BISEUxQ)
  • test-windows11-64-24h2/opt-web-platform-tests-webgpu-backlog-3 - 3 of 3 failed on the same (retriggered) task (failed: dSU_wkNdRQSUOh0GT9MVXA, dYX3KknDTQaATvUuBjP9TA, NjVreF0cSB6CFPSSsM2LiQ)
  • test-windows11-64-24h2/opt-web-platform-tests-webgpu-backlog-long-3 - 2 of 3 failed on the same (retriggered) task (failed: e9dV9tY_S8eXuB-S26vghg, OXp8-R26Rm67qjwqjun2cQ)
  • test-windows11-64-24h2/opt-web-platform-tests-webgpu-backlog-4 - 3 of 3 failed on the same (retriggered) task (failed: Hm15beMhSbKzDBmiTUTKLg, MHfacRDOTean8P95frmLVw, QxVF8LiETkWvNLCSUqlB2w)
  • test-windows11-64-24h2/opt-web-platform-tests-webgpu-backlog-12 - 2 of 3 failed on the same (retriggered) task (failed: JHSG0qbCTY6loN5mzr-nNg, Kgdn_d_yQNC1rTmWzxRP-A)
  • test-macosx1470-64/opt-web-platform-tests-webgpu-backlog-long-5 - 2 of 3 failed on the same (retriggered) task (failed: BkGaY94fQ0urcxjlQwrpsw, ZBUmTp5rRoKbx0GdfBmtxg)
  • test-macosx1470-64/opt-web-platform-tests-webgpu-backlog-9 - 3 of 3 failed on the same (retriggered) task (failed: C_haeT01TQqnuNBBCeIlzA, FMjUitOTTcW5F4820E-iqQ, Y5Pql9OORXmRZntvY7F-Gw)
  • test-macosx1470-64/opt-web-platform-tests-webgpu-backlog-10 - 2 of 3 failed on the same (retriggered) task (failed: Cu0sV0b_Q6WeV5dgnQ1J5A, SDqiEMciRl-a2bKqIuKxgQ)
  • test-macosx1470-64/opt-web-platform-tests-webgpu-backlog-long-1 - 1 of 3 failed on the same (retriggered) task (failed: HgQNBrKIQ520TBb0bEO7ug)
  • test-macosx1470-64/opt-web-platform-tests-webgpu-backlog-long-3 - 2 of 3 failed on the same (retriggered) task (failed: eqMGIQP7SCCBLTz9c-XD5g, fbwE4xaFQwKr4NUaWuqYVA)
  • test-linux2204-64-wayland/debug-web-platform-tests-webgpu-backlog-long-2 - 2 of 3 failed on the same (retriggered) task (failed: bVSz8X6tQ5SPpKUYKmoxjg, Y4EXEzrqSPOSqFKewhs3zg)
  • test-linux2204-64-wayland/debug-web-platform-tests-webgpu-18 - 1 of 3 failed on the same (retriggered) task (failed: c84F3_XtSvuTaaIIVIySHw)
  • test-linux2204-64-wayland/debug-web-platform-tests-webgpu-backlog-long-4 - 1 of 3 failed on the same (retriggered) task (failed: Ct806xr3R_WMKobdIraW7Q)
  • test-linux2204-64-wayland/debug-web-platform-tests-webgpu-backlog-long-3 - 2 of 3 failed on the same (retriggered) task (failed: eoADU6jATJ-gXJpcDwvNpQ, ZvpwJb8zTcKEovZtC4PqGw)
  • test-linux2204-64-wayland/debug-web-platform-tests-webgpu-backlog-16 - 3 of 3 failed on the same (retriggered) task (failed: fBB2P-ZySYuEgNPCbO709A, eT-OZchoTaC-0a8o4OND-g, WdhlYLdARGCrjeRSRJVRpg)
  • test-linux2204-64-wayland/debug-web-platform-tests-webgpu-backlog-12 - 1 of 3 failed on the same (retriggered) task (failed: RVxbpjF2Ra2UwwAWa6ceDQ)
  • test-linux2204-64-wayland/debug-web-platform-tests-webgpu-backlog-long-1 - 1 of 3 failed on the same (retriggered) task (failed: HWFiqdn7RVCrS9AouZIlCA)
  • test-linux2204-64-wayland/debug-web-platform-tests-webgpu-backlog-9 - 3 of 3 failed on the same (retriggered) task (failed: IfCQbVBSQTeKMQP0UA28vw, JlGUeQgNSi-u9tV7RqeTqA, Nd-7PB_8RfWZmfWPzVDTPQ)
  • test-linux2204-64-wayland/debug-web-platform-tests-webgpu-backlog-19 - 2 of 3 failed on the same (retriggered) task (failed: UJQuxFWiRgmxr_dcuyp93w, Z4G7e85KROaX2CZ0Prz2Iw)
  • test-windows11-64-24h2/debug-web-platform-tests-webgpu-backlog-9 - 1 of 3 failed on the same (retriggered) task (failed: a8-u_QtwTJ2bCFKvWXjVVA)
  • test-windows11-64-24h2/debug-web-platform-tests-webgpu-backlog-3 - 3 of 3 failed on the same (retriggered) task (failed: bS0Ex0eYSgqnJLAzSL6o3w, HgCQV_dZTFK9muJ7tTyXyA, VkIU027zRO-IYEyTufp5TQ)
  • test-windows11-64-24h2/debug-web-platform-tests-webgpu-backlog-long-3 - 3 of 3 failed on the same (retriggered) task (failed: dAVrcnYmTQ2FPFbgCxAMHg, Htucl_IeSWeVdybwRtMDLA, Jk3sEKZQSvSd995ndg-pJA)
  • test-windows11-64-24h2/debug-web-platform-tests-webgpu-backlog-8 - 3 of 3 failed on the same (retriggered) task (failed: ELnPQO-cRP2PiV4_GMovYA, EmJuSDGTSo6w-om_9d6uQQ, QbMv1vhpSPqf90wecRjHFA)
  • test-windows11-64-24h2/debug-web-platform-tests-webgpu-backlog-long-4 - 1 of 3 failed on the same (retriggered) task (failed: TR0T4rRTQNCKpWRsyahdig)
  • test-macosx1470-64/debug-web-platform-tests-webgpu-backlog-long-5 - 3 of 3 failed on the same (retriggered) task (failed: ASpcLbXGTBSN0EAP6gKkUg, Jf-YYd1hQ9Sv2xraKW1D0Q, Kh2-Vo7SQjuHJLDjxtM2JQ)
  • test-macosx1470-64/debug-web-platform-tests-webgpu-backlog-25 - 1 of 3 failed on the same (retriggered) task (failed: AT4Ucp78SOO-vXeloYhiaw)
  • test-macosx1470-64/debug-web-platform-tests-webgpu-backlog-long-4 - 3 of 3 failed on the same (retriggered) task (failed: Bfvc3vdVSpy1Dc3n2lhSiw, BW3l8lcJSMS7yfOr0NHgXQ, P6vIBPsrQZ2rKDGNrW8J_g)
  • test-macosx1470-64/debug-web-platform-tests-webgpu-backlog-7 - 1 of 3 failed on the same (retriggered) task (failed: D7G7fX43RQiCs8UhrqAAUg)
  • test-macosx1470-64/debug-web-platform-tests-webgpu-backlog-long-3 - 3 of 5 failed on the same (retriggered) task (failed: DBsEB4xnQ2qqBoZueeI2NA, RF1dsp0qQ1SSrftfBcirbA, We1AmAshSGus4OFVBWdIkA)
  • test-macosx1470-64/debug-web-platform-tests-webgpu-backlog-9 - 3 of 3 failed on the same (retriggered) task (failed: DftGJ0xSQfujPoKqe8OeBw, eV-cstPKQ86kcLhB_hDVug, OZZp_49YSAGLTn0OWEuEaQ)
  • test-macosx1470-64/debug-web-platform-tests-webgpu-backlog-18 - 3 of 3 failed on the same (retriggered) task (failed: dOaw39s4RrK4Ih715ID0Wg, FFGOjH8wSnq9X5N349hdbw, WdzWxfgWSZ6JJdmYK51wDA)
  • test-macosx1470-64/debug-web-platform-tests-webgpu-backlog-10 - 2 of 3 failed on the same (retriggered) task (failed: HEF4LoJmRVWfLstPWHIQTQ, N9R4jErrQU-rc9DbDQhQEA)
  • test-macosx1470-64/debug-web-platform-tests-webgpu-backlog-long-1 - 2 of 3 failed on the same (retriggered) task (failed: OCMl6NxHTXC9vx0nlCOffA, PWya-7qNTmCrmlBr-7lCoA)
  • test-macosx1470-64/debug-web-platform-tests-webgpu-backlog-19 - 1 of 3 failed on the same (retriggered) task (failed: Xwa1iyyOSGq1oN7S2aa0Sw)
  • test-macosx1470-64/debug-web-platform-tests-webgpu-backlog-17 - 1 of 3 failed on the same (retriggered) task (failed: ONDEOn31TDOK2YWFM_7ybQ)

Needs Investigation (Possible Intermittents):

  • test-linux2204-64-wayland/debug-web-platform-tests-webgpu-21 - 1 of 3 failed on the same (retriggered) task (failed: SNB5DzAoTkmsaCowH7UbdQ)
  • test-linux2204-64-wayland/debug-web-platform-tests-webgpu-11 - 1 of 3 failed on the same (retriggered) task (failed: ZQop-yjkTCeTX5iJ8VehMQ)
  • test-linux2204-64-wayland/debug-web-platform-tests-webgpu-backlog-13 - 1 of 3 failed on the same (retriggered) task (failed: QxpPRWhiRuWakuWwbKqPYw)

Known Issues:

  • _mozilla/webgpu/cts/webgpu/api/operation/storage_texture/read_only/cts.https.html?q=webgpu:api,operation,storage_texture,read_only:basic:*
    - test-windows11-64-24h2/debug-web-platform-tests-webgpu-12 (dJ1R3UKeQfCh0XgPVqf_cw)
    - test-windows11-64-24h2/debug-web-platform-tests-webgpu-12 (H0tylD2QR5K4ZUbg7_efzg)
    - test-windows11-64-24h2/debug-web-platform-tests-webgpu-12 (KpTI4kkzQOG2zyU4N-O-Zg)
    - test-macosx1470-64/debug-web-platform-tests-webgpu-12 (fspAtroqRrmrw-8iFvQydg)
    - test-macosx1470-64/debug-web-platform-tests-webgpu-12 (QEwX0QGkSJeVgaN1T3Ihjg)
    - test-macosx1470-64/debug-web-platform-tests-webgpu-12 (TkFGYgcLRuOqASymSyeSvQ)
    - test-windows11-64-24h2/opt-web-platform-tests-webgpu-12 (BMFFqJ0iRCuzOO7Fi_gWIw)
    - test-windows11-64-24h2/opt-web-platform-tests-webgpu-12 (JyATktu0REy34lFxg5yOVw)
    - test-windows11-64-24h2/opt-web-platform-tests-webgpu-12 (QoYl5fVdSYu6tDizen_tLA)
    - test-macosx1470-64/opt-web-platform-tests-webgpu-12 (KAUYhp_2SgOqQJTap5oqxw)
    - test-macosx1470-64/opt-web-platform-tests-webgpu-12 (Oh50ATDRQsaCe_AM3U4uXg)
    - test-macosx1470-64/opt-web-platform-tests-webgpu-12 (WL6lPoyoSwGfrAZoTxz3iQ)

These failures could mean that the library update changed something and caused
tests to fail. You'll need to review them yourself and decide where to go from here.

In either event, I have done all I can and you will need to take it from here. If you
don't want to land my patch, you can replicate it locally for editing with
./mach vendor dom/webgpu/tests/cts/moz.yaml

When reviewing, please note that this is external code, which needs a full and
careful inspection - not a rubberstamp.

Flags: needinfo?(egubler)

Already updated the patch stack. 😀

Flags: needinfo?(egubler)
Keywords: leave-open
Pushed by egubler@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/6ee1964e4877 https://hg.mozilla.org/integration/autoland/rev/342fd8ece292 test(webgpu): sync `implementation-status` for `webgpu:api,operation,storage_texture,read_only:basic:*` r=webgpu-reviewers,teoxoy

This bug is being closed because a newer revision of the library is available.
This bug will be marked as a duplicate of it (because although this bug is older, it is superseded by the newer one).

Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Duplicate of bug: 1986136
Resolution: --- → DUPLICATE

Updatebot encountered an error while trying to abandon the phabricator patch 262228.
Updatebot will be unable to do anything more for this library version.

Status: RESOLVED → REOPENED
No longer duplicate of bug: 1986136
Resolution: DUPLICATE → ---
Pushed by egubler@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/edc558c7cd68 https://hg.mozilla.org/integration/autoland/rev/fe850ede122b test(webgpu): update CTS to 0fb20da2efe90a2c38228709038f97b565dfc85c r=webgpu-reviewers,teoxoy https://github.com/mozilla-firefox/firefox/commit/727f98387cec https://hg.mozilla.org/integration/autoland/rev/f78c1c1a43a4 test(webgpu): accept observed intermittents r=webgpu-reviewers,teoxoy
Status: REOPENED → RESOLVED
Closed: 3 months ago3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 144 Branch
QA Whiteboard: [qa-triage-done-c145/b144]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: