Closed Bug 1984943 Opened 5 months ago Closed 4 months ago

Avoid mocking logger in tests

Categories

(Conduit :: moz-phab, task)

Product:
Conduit
Component:
moz-phab
Type:
task

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: mathew.hodson, Assigned: mathew.hodson)

Details

Attachments

(1 file)

tests: avoid mocking logger (Bug 1984943) r=sheehan
48 bytes, text/x-phabricator-request
Details | Review

In D262225#9064542, @sheehan wrote:

Much better, thanks!

Looking at the repo, it seems we have similar logging mocks in a few more files:

  • test_abandon.py
  • test_git.py
  • test_reorganise.py
  • test_helpers.py

If you are able to take a look at removing the logger mocks from those files too that would be excellent. :)

Assignee: nobody → mathew.hodson
Status: NEW → ASSIGNED

Authored by https://github.com/mathewhodson
https://github.com/mozilla-conduit/review/commit/a13ae0c0b8dc282c455585ce56ce39354a87bd8d
[main] tests: avoid mocking logger (Bug 1984943) r=sheehan

Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: