1984948 - [wpt-sync] Sync PR 54492 - [Editing] Fix removeFormat incorrectly preserving background-color on child elements

Status: RESOLVED FIXED

(Core :: DOM: Editor, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 54492 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/54492
Details from upstream follow.

Pranav Modi <[e-mail]> wrote:

[Editing] Fix removeFormat incorrectly preserving background-color on child elements

When removeFormat was applied to styled elements like bold, the
background-color was being pushed down to child elements instead of
being removed completely. This CL fixes it by filtering
style_to_push_down to exclude CSS properties that are targeted for
removal by the removeFormat operation.

Bug: 41438799
Change-Id: Idc4a9b091769dbd6c401b943a33bfb9433795f7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6865693
Reviewed-by: Sambamurthy Bandaru \<[e-mail]>
Commit-Queue: Pranav Modi \<[e-mail]>
Reviewed-by: Kent Tamura \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1505702}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=6dd54d4cfe25ac6c372d1a49a8555dab3df0f1e2

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Attachment: Notable wpt changes

# CI Results

Ran 12 Firefox configurations based on mozilla-central

Total 498 tests and 4 subtests

## Status Summary

### Firefox
`OK`   : 491[Gecko-linux2404-64-debug] 492[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-windows11-32-24h2-debug, Gecko-windows11-64-24h2-debug] 497[Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-opt]
`PASS` : 14736[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-linux2404-64-debug, Gecko-windows11-32-24h2-debug, Gecko-windows11-64-24h2-debug] 14776[Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-opt]
`FAIL` : 1698[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-linux2404-64-debug, Gecko-windows11-32-24h2-debug, Gecko-windows11-64-24h2-debug] 1713[Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-opt]
`ERROR`: 1

## Links
[Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=6dd54d4cfe25ac6c372d1a49a8555dab3df0f1e2)

## Details

(See attachment for full changes)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/cb8377c9d2ab
https://hg.mozilla.org/integration/autoland/rev/4625bff4829e
[wpt PR 54492] - [Editing] Fix removeFormat incorrectly preserving background-color on child elements, a=testonly

Comment 4

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/4625bff4829e