1984953 - Log pollution from content process module events after Session is destroyed

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, defect, P3)

Description

[Julian Descottes [:jdescottes]]

Until Bug 1730913 is addressed, content process modules might still process and emit events which will be received by the parent process. We don't unregister the JSWindowActor pair when closing the session, so any event emitted by a content module will still be handled by the MessageHandlerFrameParent.sys.mjs file at https://searchfox.org/firefox-main/rev/4b63e8e14125558cd75be1a53b6fc40b48cc2560/remote/shared/messagehandler/transports/js-window-actors/MessageHandlerFrameParent.sys.mjs#110-122

async #handleMessageHandlerEventMessage(messageData) {
  const { name, contextInfo, data, sessionId } = messageData;
  const [moduleName] = name.split(".");

  const messageHandler =
    lazy.RootMessageHandlerRegistry.getExistingMessageHandler(sessionId);

  const module = messageHandler.moduleCache.getModuleInstance(moduleName, {
    type: lazy.WindowGlobalMessageHandler.type,
  });

However if the session is destroyed, messageHandler will be undefined and the call to messageHandler.moduleCache.getModuleInstance will throw and pollute the logs.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1984953 - [bidi] Avoid log pollution from content process modules after session is destroyed

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3a4933ce925e
https://hg.mozilla.org/integration/autoland/rev/b96a18bbd257
[bidi] Avoid log pollution from content process modules after session is destroyed r=webdriver-reviewers,whimboo

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/b96a18bbd257