1984981 - [composable toolbar] Tapping on the loaded URL doesn't display the keyboard when trending / recent searches are enabled

Status: VERIFIED FIXED

(Firefox for Android :: Toolbar, defect, P2)

Description

[Mira Lobontiu (Android QA)]

Attachment: 25-08-25-12-26-11.mp4

Precondition

Have VPN set to US.

Steps to reproduce

1. Enable Trending searches, Recent searches, and Composable toolbar from Secret settings.
2. Open a website.
3. After it is fully loaded, tap on the toolbar.
4. Observe if the keyboard is displayed.

Expected behavior

The keyboard is displayed and functional. The user can search for something else.

Actual behavior

The keyboard isn't displayed. The user cannot search for something else, unless a new tab is opened.

Device information

• Firefox version: Nightly 144.0a1 from 8/24
• Android devices: Samsung Galaxy S24 (Android 15), and OnePlus 5 (Android 10)

Any additional information?

• the issue is not reproducible when Composable toolbar is disabled,
• the issue is not reproducible when trending and recent searches are disabled

Comment 1

[Petru-Mugurel Lingurar [:petru]]

The stacktrace from bug 1984977 applies here also with the exception there

java.lang.IllegalArgumentException: performMeasureAndLayout called during measure layout

showing the race between the InlineAutocompleteEditText (View) and the rest of the composable code.

Comment 2

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1984981 - Update the layout for showing the clipboard banner r=#android-reviewers

Investigations shown a race between the measure/layout phases of the
InlineAutocompleteEditText (View) and the rest of the composable layout
for showing search results.
Until being able to convert that View to Compose the best we can do is
build our layout in such a way to avoid the issue. Since the suggestions
content is already shown in a Column we can avoid the new Column
composable which shows the issue fixed.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6478d77d0fed
https://hg.mozilla.org/integration/autoland/rev/7c3fbc4aac66
Update the layout for showing the clipboard banner r=android-reviewers,sfamisa

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/7c3fbc4aac66

Comment 5

[Mira Lobontiu (Android QA)]

Verified as fixed on today's Nightly 144.0a1 (8/26) with Samsung Galaxy S24 (Android 15), and OnePlus 5 (Android 10).

Comment 6

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1984981 - Update the layout for showing the clipboard banner r=#android-reviewers

Investigations shown a race between the measure/layout phases of the
InlineAutocompleteEditText (View) and the rest of the composable layout
for showing search results.
Until being able to convert that View to Compose the best we can do is
build our layout in such a way to avoid the issue. Since the suggestions
content is already shown in a Column we can avoid the new Column
composable which shows the issue fixed.

Original Revision: https://phabricator.services.mozilla.com/D262337

Comment 7

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: Broken functionality. Potential crash.
• Code covered by automated testing: no
• Fix verified in Nightly: yes
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: Steps in https://bugzilla.mozilla.org/show_bug.cgi?id=1984981#c0
• Risk associated with taking this patch: Low
• Explanation of risk level: Small change verified by QA.
• String changes made/needed: No
• Is Android affected?: yes

Comment 8

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/fffb43e7a9a5
https://hg.mozilla.org/releases/mozilla-beta/rev/63d3b080e436

Comment 9

[Mira Lobontiu (Android QA)]

Verified as fixed on the latest Firefox for Android beta 143.0b6 with a Pixel Tablet (Android 16), and Samsung Galaxy S24 (Android 15).