1985121 - Remove pref for Math.sumPrecise proposal

Status: RESOLVED FIXED

(Core :: JavaScript: Standard Library, task, P3)

Description

[Dan Minor [:dminor]]

This shipped over six months ago and now is at Stage 4, we can safely remove the preference.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit BugBot documentation.

Comment 2

[Hiren Sharma [:hiirrxnn]]

Hi, I’d like to work on this bug if it’s still available. I recently completed Bug 2003174 involving preference cleanup.

Comment 3

[Dan Minor [:dminor]]

Great, thank you! For this, you'll want a SpiderMonkey build available. There's instructions here: https://firefox-source-docs.mozilla.org/js/build.html.

Roughly what you need to do is the following:

1. Remove the pref from StaticPrefList.yaml
2. Remove the shell command line option and handling
3. Remove the exposure check in JSObject.cpp
4. Remove the feature check in test262-update.py
5. Re-import the test262 tests following the instructions. This will allow the tests to run without the shell command line option we removed in step 2.
6. Make sure the tests still run ok, e.g. run mach jstests and mach jit-test.

Please let me know if you run into any problems :)

Comment 4

[witty.31.06]

Attachment: Bug 1985121: Removed pref for Math.sumPrecise.r=dminor

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/98198d892d46
https://hg.mozilla.org/integration/autoland/rev/340d264c5694
Removed pref for Math.sumPrecise.r=dminor

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/340d264c5694